Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 6542066: Sputnik tests - forward to r94. (Closed)

Created:
9 years, 10 months ago by Martin Maly
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Sputnik tests - forward to r94. BUG= TEST=

Patch Set 1 #

Total comments: 8

Patch Set 2 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -19 lines) Patch
M test/sputnik/README View 1 chunk +2 lines, -2 lines 0 comments Download
M test/sputnik/sputnik.status View 1 2 chunks +33 lines, -16 lines 0 comments Download
M test/sputnik/testcfg.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Martin Maly
This brings Sputnik tests to current head. Recently Sputnik introduced a flag that runs all/some ...
9 years, 10 months ago (2011-02-22 20:36:36 UTC) #1
Lasse Reichstein
LGTM http://codereview.chromium.org/6542066/diff/1/test/sputnik/sputnik.status File test/sputnik/sputnik.status (right): http://codereview.chromium.org/6542066/diff/1/test/sputnik/sputnik.status#newcode193 test/sputnik/sputnik.status:193: # with undefined/null. Test expects otherwise. Object.prototype.toString has ...
9 years, 10 months ago (2011-02-23 06:12:32 UTC) #2
Martin Maly
Thanks, Lasse, for reviewing. Rico, if you are ok with the change, feel free to ...
9 years, 10 months ago (2011-02-23 18:12:10 UTC) #3
Rico
9 years, 10 months ago (2011-02-24 06:39:42 UTC) #4
Landed in revision 6918

On 2011/02/23 18:12:10, Martin Maly wrote:
> Thanks, Lasse, for reviewing.
> 
> Rico, if you are ok with the change, feel free to commit it and update the
build
> bots.
> 
> Thank you!
> Martin
> 
> http://codereview.chromium.org/6542066/diff/1/test/sputnik/sputnik.status
> File test/sputnik/sputnik.status (right):
> 
>
http://codereview.chromium.org/6542066/diff/1/test/sputnik/sputnik.status#new...
> test/sputnik/sputnik.status:193: # with undefined/null. Test expects
otherwise.
> On 2011/02/23 06:12:32, Lasse Reichstein wrote:
> > Object.prototype.toString has special cases for null and undefined as the
two
> > first steps of the algorithm. After that, it does ToObject on the remaining
> > values.
> 
> Cleaned up. These 2 failures are captured below as well as a V8 bug.
> 
>
http://codereview.chromium.org/6542066/diff/1/test/sputnik/sputnik.status#new...
> test/sputnik/sputnik.status:199: # V8 should not wrap this when calling
builtin
> functions
> On 2011/02/23 06:12:32, Lasse Reichstein wrote:
> > We should have avoided that already. Are we wrapping this now?
> 
> not wrapping for builtins is on my todo list still. Some builtins may already
> work but not the builtins implemented in javascript themselves. Once that's
> done, all these tests will start passing.
> 
>
http://codereview.chromium.org/6542066/diff/1/test/sputnik/sputnik.status#new...
> test/sputnik/sputnik.status:223: S15.3_A3_T1: FAIL
> On 2011/02/23 06:12:32, Lasse Reichstein wrote:
> > Agree.
> 
> Done.
> 
>
http://codereview.chromium.org/6542066/diff/1/test/sputnik/sputnik.status#new...
> test/sputnik/sputnik.status:225: S15.3_A3_T3: FAIL
> On 2011/02/23 06:12:32, Lasse Reichstein wrote:
> > And agree. 
> > The tests did depend on a variable not being present before the assignment
to
> > the global property.
> 
> Done.

Powered by Google App Engine
This is Rietveld 408576698