Issue 6542043: Remove /mnt/partner_partition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6542043: Remove /mnt/partner_partition (Closed)

Created:
9 years, 10 months ago by Dmitry Polukhin

Modified:
9 years, 7 months ago

Reviewers:
gauravsh, jrbarnette

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/init.git@master

Visibility:
Public.

Description

Remove /mnt/partner_partition BUG=chromium-os:6840 TEST=no Chrome OS build breakage Change-Id: If4d860d770eb9fc48cf3cafb406690b22822e383 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3175767

Patch Set 1 #

Patch Set 2 : rebase #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -8 lines)			Patch
	M	chromeos_shutdown	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	chromeos_startup	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jrbarnette

LGTM! Anything that deletes code from chromeos_startup is a Good Thing (TM). Thanks!

9 years, 10 months ago (2011-02-22 17:33:23 UTC) #2

gauravsh

LGTM, though please test if this change (and the combination of all changes) does not ...

9 years, 10 months ago (2011-02-22 18:55:03 UTC) #3

Dmitry Polukhin

On 2011/02/22 18:55:03, gauravsh wrote: > LGTM, though please test if this change (and the ...

9 years, 10 months ago (2011-02-22 19:12:28 UTC) #4

gauravsh

9 years, 10 months ago (2011-02-22 20:22:06 UTC) #5

On Tue, Feb 22, 2011 at 11:12 AM, <dpolukhin@chromium.org> wrote:

> On 2011/02/22 18:55:03, gauravsh wrote:
>
>> LGTM, though please test if this change (and the combination of all
>> changes)
>> does not break anything before submitting
>>
>
> I tested all 3 changes together - no build or update issues detected.


Ok, cool. Still LGTM.


>
>
> http://codereview.chromium.org/6542043/
>



-- 
-g

Expand Messages | Collapse Messages