Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 6542028: Log the number of objects in a Pack when it is deleted in debug builds to hel... (Closed)

Created:
9 years, 10 months ago by Tristan Schmelcher 2
Modified:
9 years, 6 months ago
Reviewers:
milligan, gangji, zhurunz, Tim H
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

Log the number of objects in a Pack when it is deleted in debug builds to help JS app developers find leaks. TEST=used it in a JS app to help identify a leak BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75441

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M core/cross/pack.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Tristan Schmelcher 2
9 years, 10 months ago (2011-02-18 20:40:56 UTC) #1
zhurunz
Should this be an assert also?
9 years, 10 months ago (2011-02-18 20:45:01 UTC) #2
milligan
LGTM
9 years, 10 months ago (2011-02-18 20:45:58 UTC) #3
Tristan Schmelcher 2
On 2011/02/18 20:45:01, zhurunz wrote: > Should this be an assert also? Tim suggested the ...
9 years, 10 months ago (2011-02-18 20:55:10 UTC) #4
gangji
9 years, 10 months ago (2011-02-18 21:13:41 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698