Issue 6542026: Callback: De-inline CallbackBase, and move to callback_helpers -> callback_internal.h

Issue 6542026: Callback: De-inline CallbackBase, and move to callback_helpers -> callback_internal.h (Closed)

Created:
9 years, 10 months ago by awong

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher, akalin

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org, willchan no longer on Chromium, darin (slow to review), brettw

Base URL:
svn://svn.chromium.org/chrome/trunk/src/base

Visibility:
Public.

Description

Callback: De-inline CallbackBase, and move to callback_helpers -> callback_internal.h We can re-inline later if it starts being an issue. BUG=none TEST=unit-tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75443 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75464

Patch Set 2 : address comments #

Patch Set 3 : add in the destrcutor actually #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+131 lines, -149 lines)			Patch
M	base/base.gypi	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	base/bind.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/bind.h.pump	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/bind_internal.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/bind_internal.h.pump	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/callback.h	View		2 chunks	+1 line, -44 lines	0 comments	Download
M	base/callback.h.pump	View		2 chunks	+1 line, -44 lines	0 comments	Download
D	base/callback_helpers.h	View	1	1 chunk	+0 lines, -55 lines	0 comments	Download
A	base/callback_internal.h	View	1	1 chunk	+86 lines, -0 lines	0 comments	Download
A	base/callback_internal.cc	View	1 2	1 chunk	+36 lines, -0 lines	0 comments	Download
M	base/callback_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

http://codereview.chromium.org/6542026/diff/1/base/callback_internal.h File base/callback_internal.h (right): http://codereview.chromium.org/6542026/diff/1/base/callback_internal.h#newcode72 base/callback_internal.h:72: scoped_refptr<InvokerStorageBase>* invoker_storage); Drive by: add a destructor. The autogenerated ...

9 years, 10 months ago (2011-02-18 20:39:11 UTC) #2

akalin

LGTM after nit and drive-by http://codereview.chromium.org/6542026/diff/1/base/callback_internal.cc File base/callback_internal.cc (right): http://codereview.chromium.org/6542026/diff/1/base/callback_internal.cc#newcode25 base/callback_internal.cc:25: scoped_refptr<InvokerStorageBase>* invoker_storage) indentation

9 years, 10 months ago (2011-02-18 20:49:47 UTC) #3

awong

9 years, 10 months ago (2011-02-18 21:27:24 UTC) #4

http://codereview.chromium.org/6542026/diff/1/base/callback_internal.cc
File base/callback_internal.cc (right):

http://codereview.chromium.org/6542026/diff/1/base/callback_internal.cc#newco...
base/callback_internal.cc:25: scoped_refptr<InvokerStorageBase>*
invoker_storage)
On 2011/02/18 20:49:47, akalin wrote:
> indentation

Done.

http://codereview.chromium.org/6542026/diff/1/base/callback_internal.h
File base/callback_internal.h (right):

http://codereview.chromium.org/6542026/diff/1/base/callback_internal.h#newcode72
base/callback_internal.h:72: scoped_refptr<InvokerStorageBase>*
invoker_storage);
On 2011/02/18 20:39:11, Elliot Glaysher wrote:
> Drive by: add a destructor. The autogenerated one would probably be larger
than
> the declared ctor through scoped_refptr<> since it'll have to do deallocation.


Done. Added comment summarizing our IM discussion too.

Expand Messages | Collapse Messages