Issue 6542018: Fix a regression when switching the options pane to use Dom UI: when a user c...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6542018: Fix a regression when switching the options pane to use Dom UI: when a user c... (Closed)

Created:
9 years, 10 months ago by robertshield

Modified:
9 years, 6 months ago

Reviewers:
stuartmorgan, Evan Stade

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix a regression when switching the options pane to use Dom UI: when a user clicks the "Make Chrome my default browser" button, we should reset the browser.check_default_browser to true. BUG=73208 TEST=Follow steps listed in bug, observe that the infobar again shows up. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75401

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/dom_ui/options/browser_options_handler.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

robertshield

Looks like setting the browser check pref regressed in the DOMUI options implementation and this ...

9 years, 10 months ago (2011-02-18 16:03:37 UTC) #1

LGTM; sorry that got dropped.

Expand Messages | Collapse Messages