Get rid of browser_prefs::RegisterAllPrefs()

chrome/test/testing_browser_process.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // An implementation of BrowserProcess for unit tests that fails for most
 // services. By preventing creation of services, we reduce dependencies and
 // keep the profile clean. Clients of this class must handle the NULL return
 // value, however.
 
 #ifndef CHROME_TEST_TESTING_BROWSER_PROCESS_H_
@@ skipping 133 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(TestingBrowserProcess);
 };
 
 // Scoper to put a TestingBrowserProcess in |g_browser_process|.
 class ScopedTestingBrowserProcess {
  public:
   ScopedTestingBrowserProcess();
   ~ScopedTestingBrowserProcess();
 
+  TestingBrowserProcess* get() {

[Paweł Hajdan Jr., 2011/02/18 17:03:43]

That seems wrong, I think the code should just use g_browser_process.

[Mattias Nissler (ping if slow), 2011/02/18 17:08:04]

See my other comment for why this is here. Would you rather like the typecast?

+    return browser_process_.get();
+  }
+
  private:
   // TODO(phajdan.jr): Temporary, for http://crbug.com/61062.
   // After the transition is over, we should just stack-allocate it.
   scoped_ptr<TestingBrowserProcess> browser_process_;
 
   DISALLOW_COPY_AND_ASSIGN(ScopedTestingBrowserProcess);
 };
 
 #endif  // CHROME_TEST_TESTING_BROWSER_PROCESS_H_