X64 Crankshaft: Implement LValueOf and (dummy) LArgumentsObject.

X64 Crankshaft: Implement LValueOf and (dummy) LArgumentsObject.

Committed: http://code.google.com/p/v8/source/detail?r=6850

[Lasse Reichstein, 2011-02-18 11:50:55]

LGTM

http://codereview.chromium.org/6542011/diff/4002/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):

http://codereview.chromium.org/6542011/diff/4002/src/ia32/lithium-ia32.cc#new...
src/ia32/lithium-ia32.cc:1981: return NULL;
What is the "value" that is never used?
Is this function never called, or is its return value never used (and if so, how
do we know that)?
If it's never called, it should either assert that, or do a bailout if it ever
got called anyway.
If the return value isn't used, why are we calling the function?

[William Hesse, 2011-02-18 12:06:21]

http://codereview.chromium.org/6542011/diff/4002/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):

http://codereview.chromium.org/6542011/diff/4002/src/ia32/lithium-ia32.cc#new...
src/ia32/lithium-ia32.cc:1981: return NULL;
A HValue, HArgumentsObject is created to represent the arguments object.  Once
we figure it out, we will use this object.  Currently, we don't compile any uses
of it in Crankshaft, so the HValue turns into zero lithium instructions.  The
way to create zero lithium instructions for an HValue is to return null from
DoH...().
In the long run, this should be implemented or HArgumentsObject should be
removed.


On 2011/02/18 11:50:55, Lasse Reichstein wrote:
> What is the "value" that is never used?
> Is this function never called, or is its return value never used (and if so,
how
> do we know that)?
> If it's never called, it should either assert that, or do a bailout if it ever
> got called anyway.
> If the return value isn't used, why are we calling the function?