Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 6542010: Revert 75361 - ots roll (to r52)... (Closed)

Created:
9 years, 10 months ago by akalin
Modified:
9 years, 7 months ago
Reviewers:
bashi
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 75361 - ots roll (to r52) 75361 seems to introduce new crashes caught by reliability: "anonymous namespace'::purecall____invalid_parameter_noinfo___ots::parselookuplisttable" BUG=none TEST=ran try Review URL: http://codereview.chromium.org/6539010 TBR=bashi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75372

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
akalin
9 years, 10 months ago (2011-02-18 09:03:58 UTC) #1
Ryan Sleevi
9 years, 10 months ago (2011-02-18 09:09:36 UTC) #2
Logs:
http://build.chromium.org/p/chromium/builders/Win%20Reliability/builds/2209/s...

Context (in case logs are cycled, 2 sample stacks)

REGRESSION: NEW crash stack traces found
--------------------
Repro information:
Unfiltered URL: http://lunapic.com/
Unfiltered URL: http://www.lunapic.com/
Unfiltered URL: http://www.lunapic.com/
Unfiltered URL: http://www.lunapic.com/

Stack trace:
chrome_2590000!`anonymous namespace'::PureCall+0x3
[c:\b\build\slave\win\build\src\chrome\app\chrome_main.cc @ 152]
chrome_2590000!_invalid_parameter_noinfo+0xc
[f:\dd\vctools\crt_bld\self_x86\crt\src\invarg.c @ 125]
chrome_2590000!ots::ParseLookupListTable+0xdd
[c:\b\build\slave\win\build\src\third_party\ots\src\layout.cc @ 1252]
chrome_2590000!ots::ots_gpos_parse+0x135
[c:\b\build\slave\win\build\src\third_party\ots\src\gpos.cc @ 759]
chrome_2590000!`anonymous namespace'::ProcessGeneric+0x898
[c:\b\build\slave\win\build\src\third_party\ots\src\ots.cc @ 447]
chrome_2590000!`anonymous namespace'::ProcessWOFF+0x19f
[c:\b\build\slave\win\build\src\third_party\ots\src\ots.cc @ 313]
chrome_2590000!ots::Process+0x9c
[c:\b\build\slave\win\build\src\third_party\ots\src\ots.cc @ 602]
chrome_2590000!WebCore::OpenTypeSanitizer::sanitize+0x9d
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\platform\graphics\opentype\opentypesanitizer.cpp
@ 60]
chrome_2590000!WebCore::createFontCustomPlatformData+0x26
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\platform\graphics\skia\fontcustomplatformdata.cpp
@ 174]
chrome_2590000!WebCore::CachedFont::ensureCustomFontData+0x3b
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\loader\cache\cachedfont.cpp
@ 112]
chrome_2590000!WebCore::CSSFontFaceSource::getFontData+0x251
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\css\cssfontfacesource.cpp
@ 162]
chrome_2590000!WebCore::CSSFontFace::getFontData+0x67
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\css\cssfontface.cpp
@ 112]
chrome_2590000!WebCore::CSSSegmentedFontFace::getFontData+0x153
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\css\csssegmentedfontface.cpp
@ 106]
chrome_2590000!WebCore::CSSFontSelector::getFontData+0x407
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\css\cssfontselector.cpp
@ 543]
chrome_2590000!WebCore::FontCache::getFontData+0x59
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\platform\graphics\fontcache.cpp
@ 392]
chrome_2590000!WebCore::FontFallbackList::fontDataAt+0x4b
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\platform\graphics\fontfallbacklist.cpp
@ 105]
<snip>

--------------------
Repro information:
Unfiltered URL:
http://www.parentdish.com/2010/03/30/can-a-mom-leave-her-kid-alone-at-the-lib...

Stack trace:
chrome_2590000!`anonymous namespace'::PureCall+0x3
[c:\b\build\slave\win\build\src\chrome\app\chrome_main.cc @ 152]
chrome_2590000!_invalid_parameter_noinfo+0xc
[f:\dd\vctools\crt_bld\self_x86\crt\src\invarg.c @ 125]
chrome_2590000!ots::ParseLookupListTable+0xdd
[c:\b\build\slave\win\build\src\third_party\ots\src\layout.cc @ 1252]
chrome_2590000!ots::ots_gpos_parse+0x135
[c:\b\build\slave\win\build\src\third_party\ots\src\gpos.cc @ 759]
chrome_2590000!`anonymous namespace'::ProcessGeneric+0x898
[c:\b\build\slave\win\build\src\third_party\ots\src\ots.cc @ 447]
chrome_2590000!`anonymous namespace'::ProcessWOFF+0x19f
[c:\b\build\slave\win\build\src\third_party\ots\src\ots.cc @ 313]
chrome_2590000!ots::Process+0x9c
[c:\b\build\slave\win\build\src\third_party\ots\src\ots.cc @ 602]
chrome_2590000!WebCore::OpenTypeSanitizer::sanitize+0x9d
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\platform\graphics\opentype\opentypesanitizer.cpp
@ 60]
chrome_2590000!WebCore::createFontCustomPlatformData+0x26
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\platform\graphics\skia\fontcustomplatformdata.cpp
@ 174]
chrome_2590000!WebCore::CachedFont::ensureCustomFontData+0x3b
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\loader\cache\cachedfont.cpp
@ 112]
chrome_2590000!WebCore::CSSFontFaceSource::getFontData+0x251
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\css\cssfontfacesource.cpp
@ 162]
chrome_2590000!WebCore::CSSFontFace::getFontData+0x67
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\css\cssfontface.cpp
@ 112]
chrome_2590000!WebCore::CSSSegmentedFontFace::getFontData+0x153
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\css\csssegmentedfontface.cpp
@ 106]
chrome_2590000!WebCore::CSSFontSelector::getFontData+0x407
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\css\cssfontselector.cpp
@ 543]
chrome_2590000!WebCore::FontCache::getFontData+0x59
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\platform\graphics\fontcache.cpp
@ 392]
chrome_2590000!WebCore::FontFallbackList::fontDataAt+0x4b
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\platform\graphics\fontfallbacklist.cpp
@ 105]
chrome_2590000!WebCore::FontFallbackList::determinePitch+0x10
[c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\platform\graphics\fontfallbacklist.cpp
@ 76]
<snip>

Powered by Google App Engine
This is Rietveld 408576698