Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Issue 6542009: devserver: start using payload scripts bundled with devserver (Closed)

Created:
9 years, 10 months ago by zbehan
Modified:
9 years, 7 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_chromium.org, Nick Sanders, ericli, DaleCurtis
Visibility:
Public.

Description

devserver: start using payload scripts bundled with devserver This follows CL's which move payload generators to devutils, and removes the dependency on these scripts in src/scripts. Following this, the autogeneration of payloads by the devserver installed in chroot should work. BUG=chromium-os:5246 TEST=cros_au_test_harness Change-Id: Id3be5e140e93ee1813849f6ede6bbac53c60dde4 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=59d8aa7

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M autoupdate.py View 2 chunks +2 lines, -2 lines 0 comments Download
M buildutil.py View 1 1 chunk +8 lines, -5 lines 0 comments Download
M host/cros_generate_stateful_update_payload View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
zbehan
9 years, 10 months ago (2011-02-18 06:37:23 UTC) #1
sosa
cpl nits, ow lgtm http://codereview.chromium.org/6542009/diff/1/host/cros_generate_stateful_update_payload File host/cros_generate_stateful_update_payload (right): http://codereview.chromium.org/6542009/diff/1/host/cros_generate_stateful_update_payload#newcode30 host/cros_generate_stateful_update_payload:30: # FIXME: This is only ...
9 years, 10 months ago (2011-02-18 22:29:42 UTC) #2
zbehan
On Fri, Feb 18, 2011 at 11:29 PM, <sosa@chromium.org> wrote: > cpl nits, ow lgtm ...
9 years, 10 months ago (2011-02-18 22:55:29 UTC) #3
sosa
On Fri, Feb 18, 2011 at 2:55 PM, Zdenek Behan <zbehan@chromium.org> wrote: > > > ...
9 years, 10 months ago (2011-02-18 23:06:43 UTC) #4
zbehan
9 years, 10 months ago (2011-02-18 23:16:00 UTC) #5
sosa
9 years, 10 months ago (2011-02-18 23:17:20 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698