Refactor WebResourceService class, making it more generic. Move all the prom...

Refactor WebResourceService class, making it more generic.  Move all the promo-related code into a new PromoResourceService class that inherits WebResourceService.

This refactoring will allow us to re-use WebResourceService class for GPU Blacklist updates purpose.

This CL tries to minimize the code change and adds no new logic.

BUG=68802
TEST=unittest,promo functions working fine as before.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75403

[Zhenyao Mo, 2011-02-18 00:56:01]

Please review.

Miranda, could you tell me how to tell the promo service is working properly?

[Miranda Callahan, 2011-02-18 16:59:43]

LGTM with fixes; I patched it in and it fetches the promo just as before.  The
way to test this is to run the code for a few seconds, and then check the
Preferences in the Default folder in the user data dir; look in the "ntp"
section to make sure the data has been correctly downloaded from the promo
server.

(If you're running with an already existing user data dir, you may have to
clobber the "web_resource_cache_update" entry (removing the comma afterward, if
need be!) before doing this, to force an immediate update of the web resource
cache.)

http://codereview.chromium.org/6542003/diff/7006/chrome/browser/web_resource/...
File chrome/browser/web_resource/web_resource_service.h (right):

http://codereview.chromium.org/6542003/diff/7006/chrome/browser/web_resource/...
chrome/browser/web_resource/web_resource_service.h:27: int start_fetch_delay =
5000,  // 5 seconds
The Google C++ Style Guide doesn't allow default parameters like this -- just
pass them in, or change them to defaults and add setters if you think most
classes will just use these values.

http://codereview.chromium.org/6542003/diff/7006/chrome/browser/web_resource/...
chrome/browser/web_resource/web_resource_service.h:67: // Data are associated
with a user's profile.
Remove comment altogether; it's clear what a Profile is.

http://codereview.chromium.org/6542003/diff/7006/chrome/browser/web_resource/...
chrome/browser/web_resource/web_resource_service.h:84: // URL hosts the web
resource.
"URL that hosts the web resource."

[Zhenyao Mo, 2011-02-18 17:32:09]

Thank you very much for providing the information and help and reviewing this CL
quickly.  I really appreciate it!

http://codereview.chromium.org/6542003/diff/7006/chrome/browser/web_resource/...
File chrome/browser/web_resource/web_resource_service.h (right):

http://codereview.chromium.org/6542003/diff/7006/chrome/browser/web_resource/...
chrome/browser/web_resource/web_resource_service.h:27: int start_fetch_delay =
5000,  // 5 seconds
On 2011/02/18 16:59:43, Miranda Callahan wrote:
> The Google C++ Style Guide doesn't allow default parameters like this -- just
> pass them in, or change them to defaults and add setters if you think most
> classes will just use these values.

I removed the defaults.  Instead, I added back your original defined constant
values to the promo_resource_service.cc and use them to construct the base
class.

http://codereview.chromium.org/6542003/diff/7006/chrome/browser/web_resource/...
chrome/browser/web_resource/web_resource_service.h:67: // Data are associated
with a user's profile.
On 2011/02/18 16:59:43, Miranda Callahan wrote:
> Remove comment altogether; it's clear what a Profile is.

Done.

http://codereview.chromium.org/6542003/diff/7006/chrome/browser/web_resource/...
chrome/browser/web_resource/web_resource_service.h:84: // URL hosts the web
resource.
On 2011/02/18 16:59:43, Miranda Callahan wrote:
> "URL that hosts the web resource."

Done.