Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1283)

Unified Diff: src/runtime.cc

Issue 6542: Fix incorrect short cut test that assumed ASCII strings could be Latin1. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime.cc
===================================================================
--- src/runtime.cc (revision 465)
+++ src/runtime.cc (working copy)
@@ -1086,7 +1086,11 @@
// Notice: Doesn't include last character.
for (int i = p < m ? m - p : 0; i < m - 1; i++) {
uc32 c = pattern[i];
- if (sizeof(schar) == 1 && c > 255) return -1;
+ if (sizeof(schar) == 1 &&
+ sizeof(pchar) > 1 &&
+ c > String::kMaxAsciiCharCode) {
+ return -1;
+ }
bad_char_map[c & kBMHSignificantBitsMask] = m - 1 - i;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698