Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 6541090: Merge 79107 - 2011-02-19 Charlie Reis <creis@chromium.org>... (Closed)

Created:
9 years, 10 months ago by Mihai Parparita -not on Chrome
Modified:
9 years, 6 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/648/
Visibility:
Public.

Description

Merge 79107 - 2011-02-19 Charlie Reis <creis@chromium.org>; Reviewed by Mihai Parparita. Ensure loading has stopped in HistoryController::goToItem https://bugs.webkit.org/show_bug.cgi?id=54517 Tests that going forward within the same document does not stop loading. * http/tests/navigation/forward-to-fragment-fires-onload.html: Added. * http/tests/navigation/forward-to-fragment-fires-onload-expected.txt: Added. * http/tests/navigation/resources/forward-to-fragment-fires-onload-2.html: Added. 2011-02-19 Charlie Reis <creis@chromium.org>; Reviewed by Mihai Parparita. Ensure loading has stopped in HistoryController::goToItem https://bugs.webkit.org/show_bug.cgi?id=54517 Avoid stopping all loaders in goToItem for same document navigations or pseudo-back-forward URLs. Make HistoryController::goToItem private to force callers to go through Page::goToItem. Also add a callback to FrameLoaderClient to let clients decide whether to stop loading first. Test: http/tests/navigation/forward-to-fragment-fires-onload.html * loader/EmptyClients.h: * loader/FrameLoader.h: * loader/FrameLoaderClient.h: * loader/HistoryController.cpp: * loader/HistoryController.h: * page/Page.cpp: 2011-02-19 Charlie Reis <creis@chromium.org>; Reviewed by Mihai Parparita. Ensure loading has stopped in HistoryController::goToItem https://bugs.webkit.org/show_bug.cgi?id=54517 Call Page::goToItem instead of HistoryController::goToItem, so that FrameLoader::stopAllLoaders is called first. Also adds a callback in FrameLoaderClient for checking for pseudo-back-forward URLs. Test: http/tests/navigation/forward-to-fragment-fires-onload.html * src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::shouldStopLoadingForHistoryItem): Added. * src/FrameLoaderClientImpl.h: * src/WebFrameImpl.cpp: 2011-02-19 Charlie Reis <creis@chromium.org>; Reviewed by Mihai Parparita. Ensure loading has stopped in HistoryController::goToItem https://bugs.webkit.org/show_bug.cgi?id=54517 Add a FrameLoaderClient callback for whether to stop loading before goToItem. Test: http/tests/navigation/forward-to-fragment-fires-onload.html * WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::shouldStopLoadingForHistoryItem): Added. * WebCoreSupport/FrameLoaderClientEfl.h: 2011-02-19 Charlie Reis <creis@chromium.org>; Reviewed by Mihai Parparita. Ensure loading has stopped in HistoryController::goToItem https://bugs.webkit.org/show_bug.cgi?id=54517 Add a FrameLoaderClient callback for whether to stop loading before goToItem. Test: http/tests/navigation/forward-to-fragment-fires-onload.html * WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClientGtk::shouldStopLoadingForHistoryItem): Added. * WebCoreSupport/FrameLoaderClientGtk.h: 2011-02-19 Charlie Reis <creis@chromium.org>; Reviewed by Mihai Parparita. Ensure loading has stopped in HistoryController::goToItem https://bugs.webkit.org/show_bug.cgi?id=54517 Add a FrameLoaderClient callback for whether to stop loading before goToItem. Test: http/tests/navigation/forward-to-fragment-fires-onload.html * WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::shouldStopLoadingForHistoryItem): Added. * WebCoreSupport/FrameLoaderClientHaiku.h: 2011-02-19 Charlie Reis <creis@chromium.org>; Reviewed by Mihai Parparita. Ensure loading has stopped in HistoryController::goToItem https://bugs.webkit.org/show_bug.cgi?id=54517 Add a FrameLoaderClient callback for whether to stop loading before goToItem. Test: http/tests/navigation/forward-to-fragment-fires-onload.html * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added. * WebCoreSupport/WebFrameLoaderClient.h: 2011-02-19 Charlie Reis <creis@chromium.org>; Reviewed by Mihai Parparita. Ensure loading has stopped in HistoryController::goToItem https://bugs.webkit.org/show_bug.cgi?id=54517 Add a FrameLoaderClient callback for whether to stop loading before goToItem. Test: http/tests/navigation/forward-to-fragment-fires-onload.html * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added. * WebCoreSupport/FrameLoaderClientQt.h: 2011-02-19 Charlie Reis <creis@chromium.org>; Reviewed by Mihai Parparita. Ensure loading has stopped in HistoryController::goToItem https://bugs.webkit.org/show_bug.cgi?id=54517 Add a FrameLoaderClient callback for whether to stop loading before goToItem. Test: http/tests/navigation/forward-to-fragment-fires-onload.html * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added. * WebCoreSupport/WebFrameLoaderClient.h: 2011-02-19 Charlie Reis <creis@chromium.org>; Reviewed by Mihai Parparita. Ensure loading has stopped in HistoryController::goToItem https://bugs.webkit.org/show_bug.cgi?id=54517 Add a FrameLoaderClient callback for whether to stop loading before goToItem. Test: http/tests/navigation/forward-to-fragment-fires-onload.html * WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::shouldStopLoadingForHistoryItem): Added. * WebCoreSupport/FrameLoaderClientWinCE.h: 2011-02-19 Charlie Reis <creis@chromium.org>; Reviewed by Mihai Parparita. Ensure loading has stopped in HistoryController::goToItem https://bugs.webkit.org/show_bug.cgi?id=54517 Add a FrameLoaderClient callback for whether to stop loading before goToItem. Test: http/tests/navigation/forward-to-fragment-fires-onload.html * WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::shouldStopLoadingForHistoryItem): Added. * WebKitSupport/FrameLoaderClientWx.h: 2011-02-19 Charlie Reis <creis@chromium.org>; Reviewed by Mihai Parparita. Ensure loading has stopped in HistoryController::goToItem https://bugs.webkit.org/show_bug.cgi?id=54517 Add a FrameLoaderClient callback for whether to stop loading before goToItem. Test: http/tests/navigation/forward-to-fragment-fires-onload.html * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added. * WebProcess/WebCoreSupport/WebFrameLoaderClient.h: BUG=73444 TBR=commit-queue@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2229 lines, -18 lines) Patch
A + LayoutTests/http/tests/navigation/forward-to-fragment-fires-onload.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/navigation/forward-to-fragment-fires-onload-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/navigation/resources/forward-to-fragment-fires-onload-2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/loader/EmptyClients.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/loader/FrameLoader.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/loader/FrameLoaderClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/loader/HistoryController.h View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/WebCore/loader/HistoryController.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/WebCore/page/Page.cpp View 1 chunk +2 lines, -17 lines 0 comments Download
M Source/WebKit/chromium/src/FrameLoaderClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebFrameImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebKit/efl/ChangeLog View 1 chunk +221 lines, -0 lines 0 comments Download
M Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebKit/gtk/ChangeLog View 1 chunk +528 lines, -0 lines 0 comments Download
M Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebKit/haiku/ChangeLog View 1 chunk +93 lines, -0 lines 0 comments Download
M Source/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebKit/mac/ChangeLog View 1 chunk +632 lines, -0 lines 0 comments Download
M Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebKit/win/ChangeLog View 1 chunk +406 lines, -0 lines 0 comments Download
M Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebKit/wince/ChangeLog View 1 chunk +137 lines, -0 lines 0 comments Download
M Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebKit/wx/ChangeLog View 1 chunk +129 lines, -0 lines 0 comments Download
M Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mihai Parparita -not on Chrome
9 years, 10 months ago (2011-02-23 00:13:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698