Issue 6541088: When enabling password sync manually, use the passphrase migration flow to cr...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6541088: When enabling password sync manually, use the passphrase migration flow to cr... (Closed)

Created:
9 years, 10 months ago by John Gregg

Modified:
9 years ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

When enabling password sync manually, use the passphrase migration flow to create a passphrase, rather than the confusing "enter your existing passphrase" dialog. BUG=73791 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75769

Patch Set 1 #

Total comments: 2

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	chrome/browser/sync/profile_sync_service.cc	View		2 chunks	+4 lines, -1 line	2 comments	Download
	M	chrome/browser/sync/sync_setup_flow.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

LGTM w nits http://codereview.chromium.org/6541088/diff/1/chrome/browser/sync/profile_sync_service.cc File chrome/browser/sync/profile_sync_service.cc (right): http://codereview.chromium.org/6541088/diff/1/chrome/browser/sync/profile_sync_service.cc#newcode735 chrome/browser/sync/profile_sync_service.cc:735: SigninForPassphraseMigration(NULL); comment explaining why we do ...

9 years, 10 months ago (2011-02-23 18:10:44 UTC) #2

John Gregg

9 years, 10 months ago (2011-02-23 18:56:11 UTC) #3

On 2011/02/23 18:10:44, timsteele wrote:
> LGTM w nits
> 
>
http://codereview.chromium.org/6541088/diff/1/chrome/browser/sync/profile_syn...
> File chrome/browser/sync/profile_sync_service.cc (right):
> 
>
http://codereview.chromium.org/6541088/diff/1/chrome/browser/sync/profile_syn...
> chrome/browser/sync/profile_sync_service.cc:735:
> SigninForPassphraseMigration(NULL);
> comment explaining why we do this would be nice
> 
>
http://codereview.chromium.org/6541088/diff/1/chrome/browser/sync/profile_syn...
> chrome/browser/sync/profile_sync_service.cc:767:
> wizard_.Step(SyncSetupWizard::GAIA_LOGIN);
> Can you add a comment here why the step is necessary

Done.

Expand Messages | Collapse Messages