WebUI Prefs: Don't use display:block for labels

WebUI Prefs: Don't use display:block for labels

Separates our labels into a div and a label, so that labels are no longer display:block. Making labels display:block turns out to be undesirable because it makes the clickable area for the control the full width of the pane, rather than just the control and the label text.

BUG=69792
TEST=Click to the right of a checkbox or radio button's label; it should not active the control.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75772

[arv (Not doing code reviews), 2011-02-23 18:10:29]

This bug number seems wrong.

erik








On Tue, Feb 22, 2011 at 14:48,  <stuartmorgan@chromium.org> wrote:
> Reviewers: arv,
>
> Description:
> WebUI Prefs: Don't use display:block for labels
>
> Separates our labels into a div and a label, so that labels are no longer
> display:block. Making labels display:block turns out to be undesirable
> because
> it makes the clickable area for the control the full width of the pane,
> rather
> than just the control and the label text.
>
> BUG=70565
> TEST=Click to the right of a checkbox or radio button's label; it should not
> active the control.
>
> Please review this at http://codereview.chromium.org/6541086/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/resources/options/advanced_options.css
>  M chrome/browser/resources/options/advanced_options.html
>  M chrome/browser/resources/options/autofill_options.html
>  M chrome/browser/resources/options/browser_options.html
>  M chrome/browser/resources/options/browser_options_page.css
>  M chrome/browser/resources/options/chromeos_accounts_options.html
>  M chrome/browser/resources/options/chromeos_internet_detail.html
>  M chrome/browser/resources/options/chromeos_language_chewing_options.html
>  M chrome/browser/resources/options/chromeos_language_mozc_options.html
>  M chrome/browser/resources/options/chromeos_language_pinyin_options.html
>  M chrome/browser/resources/options/chromeos_proxy.html
>  M chrome/browser/resources/options/chromeos_system_options.html
>  M chrome/browser/resources/options/clear_browser_data_overlay.html
>  M chrome/browser/resources/options/content_settings.html
>  M chrome/browser/resources/options/language_options.css
>  M chrome/browser/resources/options/language_options.html
>  M chrome/browser/resources/options/options_page.css
>  M chrome/browser/resources/options/personal_options.html
>
>
>

[arv (Not doing code reviews), 2011-02-23 18:15:47]

LGTM