Small: Cloud print UI options fix.

chrome/browser/resources/options/advanced_options.js

Index: chrome/browser/resources/options/advanced_options.js
diff --git a/chrome/browser/resources/options/advanced_options.js b/chrome/browser/resources/options/advanced_options.js
index cefd902a1278d0fa38ff1a0dda8da96a2d4cab7b..5eb9906410aa00eea59a385eaffff902fc4e36d4 100644
--- a/chrome/browser/resources/options/advanced_options.js
+++ b/chrome/browser/resources/options/advanced_options.js
@@ -128,21 +128,24 @@ var OptionsPage = options.OptionsPage;
 
       // 'cloudPrintProxyEnabled' is true for Chrome branded builds on
       // certain platforms, or could be enabled by a lab.
-      if (!cr.isChromeOS &&
-          localStrings.getString('enable-cloud-print-proxy') == 'true') {
+      if (!cr.isChromeOS) {
         $('cloudPrintProxySetupButton').onclick = function(event) {
-          if ($('cloudPrintProxyManageButton').style.display == 'none') {
-            // Disable the button, set it's text to the intermediate state.
-            $('cloudPrintProxySetupButton').textContent =
-              localStrings.getString('cloudPrintProxyEnablingButton');
-            $('cloudPrintProxySetupButton').disabled = true;
-            chrome.send('showCloudPrintSetupDialog');
-          } else {
-            chrome.send('disableCloudPrintProxy');
+          if ($('cloud-print-proxy-section').style.display != 'none') {

[csilv, 2011/02/18 19:54:28]

This added check is unnecessary.  The entire section will be removed if cloud
printing is disabled, so any onclick handler could never possibly be called.

[Scott Byer, 2011/02/18 20:44:05]

Done.

+            if ($('cloudPrintProxyManageButton').style.display == 'none') {
+              // Disable the button, set it's text to the intermediate state.
+              $('cloudPrintProxySetupButton').textContent =
+                localStrings.getString('cloudPrintProxyEnablingButton');
+              $('cloudPrintProxySetupButton').disabled = true;
+              chrome.send('showCloudPrintSetupDialog');
+            } else {
+              chrome.send('disableCloudPrintProxy');
+            }
           }
         };
         $('cloudPrintProxyManageButton').onclick = function(event) {
-          chrome.send('showCloudPrintManagePage');
+          if ($('cloud-print-proxy-section').style.display != 'none') {

[csilv, 2011/02/18 19:54:28]

Same with this check.

[Scott Byer, 2011/02/18 20:44:05]

Done.

+            chrome.send('showCloudPrintManagePage');
+          }
         };
       }