Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: net/url_request/url_request.cc

Issue 6541021: Send fatal proxy errors to the network delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request.cc
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index 9e35fc0d58ff3b8cf9ca2f4ab494e3bc3138f367..44994f063215af61ba05ff8724b32147dafc23db 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -486,8 +486,11 @@ void URLRequest::ResponseStarted() {
URLRequestJobManager::GetInstance()->MaybeInterceptResponse(this);
if (job) {
RestartWithJob(job);
- } else if (delegate_) {
- delegate_->OnResponseStarted(this);
+ } else {
+ if (context_ && context_->network_delegate())
willchan no longer on Chromium 2011/02/18 21:02:45 context_ is always non-NULL.
jochen (gone - plz use gerrit) 2011/02/21 14:52:59 Done.
jochen (gone - plz use gerrit) 2011/02/21 15:55:53 actually, it's NULL during some unit tests
+ context_->network_delegate()->OnResponseStarted(this);
+ if (delegate_)
+ delegate_->OnResponseStarted(this);
}
}
« chrome/test/data/extensions/api_test/proxy/events/test.js ('K') | « net/http/http_network_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698