Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: tools/valgrind/chrome_tests.py

Issue 6541014: Remove Wine + Valgrind code since nobody is working on it.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/common.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/chrome_tests.py
===================================================================
--- tools/valgrind/chrome_tests.py (revision 75330)
+++ tools/valgrind/chrome_tests.py (working copy)
@@ -93,19 +93,15 @@
exe = exe + '.exe'
if not self._options.build_dir:
- if common.IsWine():
- self._options.build_dir = os.path.join(
- self._source_dir, "chrome", "Debug")
+ dirs = [
+ os.path.join(self._source_dir, "xcodebuild", "Debug"),
+ os.path.join(self._source_dir, "out", "Debug"),
+ os.path.join(self._source_dir, "build", "Debug"),
+ ]
+ if exe:
+ self._options.build_dir = FindDirContainingNewestFile(dirs, exe)
else:
- dirs = [
- os.path.join(self._source_dir, "xcodebuild", "Debug"),
- os.path.join(self._source_dir, "out", "Debug"),
- os.path.join(self._source_dir, "build", "Debug"),
- ]
- if exe:
- self._options.build_dir = FindDirContainingNewestFile(dirs, exe)
- else:
- self._options.build_dir = FindNewestDir(dirs)
+ self._options.build_dir = FindNewestDir(dirs)
cmd = list(self._command_preamble)
@@ -130,9 +126,6 @@
for arg in valgrind_test_args:
cmd.append(arg)
if exe:
- if common.IsWine():
- cmd.append(os.environ.get('WINE'))
- exe = exe + '.exe'
cmd.append(os.path.join(self._options.build_dir, exe))
# Valgrind runs tests slowly, so slow tests hurt more; show elapased time
# so we can find the slowpokes.
« no previous file with comments | « no previous file | tools/valgrind/common.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698