Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1631)

Unified Diff: tools/wine_valgrind/valgrind_skip_python.patch

Issue 6541014: Remove Wine + Valgrind code since nobody is working on it.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/wine_valgrind/valgrind-suppressions ('k') | tools/wine_valgrind/valgrind_stop_frame.patch » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/wine_valgrind/valgrind_skip_python.patch
===================================================================
--- tools/wine_valgrind/valgrind_skip_python.patch (revision 75330)
+++ tools/wine_valgrind/valgrind_skip_python.patch (working copy)
@@ -1,27 +0,0 @@
-This patch prevents valgrind from tracing into python.exe.
-TODO(thestig) generalize this and submit upstream for
-https://bugs.kde.org/show_bug.cgi?id=218689
-Index: coregrind/m_syswrap/syswrap-generic.c
-===================================================================
---- coregrind/m_syswrap/syswrap-generic.c (revision 10880)
-+++ coregrind/m_syswrap/syswrap-generic.c (working copy)
-@@ -2544,6 +2544,19 @@
- VG_(nuke_all_threads_except)( tid, VgSrc_ExitThread );
- VG_(reap_threads)(tid);
-
-+ if (VG_(clo_trace_children)) {
-+ Char** program_args = (Char**)ARG2;
-+ if (program_args && program_args[0]) {
-+ Int k = 1;
-+ for (; program_args[k]; k++) {
-+ if (VG_(strstr)(program_args[k], "python.exe") != NULL) {
-+ VG_(clo_trace_children) = False;
-+ break;
-+ }
-+ }
-+ }
-+ }
-+
- // Set up the child's exe path.
- //
- if (VG_(clo_trace_children)) {
« no previous file with comments | « tools/wine_valgrind/valgrind-suppressions ('k') | tools/wine_valgrind/valgrind_stop_frame.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698