Issue 6541001: Allow yaml file to specify default compression for images

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6541001: Allow yaml file to specify default compression for images (Closed)

Created:
9 years, 10 months ago by Bill Richardson

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler, Tom Wai-Hong Tam

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
http://git.chromium.org/git/vboot_reference.git@master

Visibility:
Public.

Description

Allow yaml file to specify default compression for images BUG=chromium-os:11490 TEST=manual cd src/platform/vboot_reference make make runbmptests Change-Id: Ia887fc1aa1de873c6da6c04995bc0a9ad6b364aa Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a7209ee

Patch Set 1 #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -1 line)			Patch
M	tests/bitmaps/TestBmpBlock.py	View	2 chunks	+33 lines, -0 lines	0 comments	Download
M	utility/bmpblk_util.c	View	1 chunk	+12 lines, -1 line	0 comments	Download
M	utility/bmpblk_utility.cc	View	2 chunks	+20 lines, -0 lines	0 comments	Download
M	utility/include/bmpblk_utility.h	View	1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

9 years, 10 months ago (2011-02-17 22:27:43 UTC) #2

LGTM

http://codereview.chromium.org/6541001/diff/1/utility/include/bmpblk_utility.h
File utility/include/bmpblk_utility.h (right):

http://codereview.chromium.org/6541001/diff/1/utility/include/bmpblk_utility....
utility/include/bmpblk_utility.h:96: void parse_compression(yaml_parser_t
*parser);
Just noticed, aren't we nestling * to the type not the variable?

Expand Messages | Collapse Messages