Issue 654013: Deprecate file_util::AppendToPath() on non-Windows.

Issue 654013: Deprecate file_util::AppendToPath() on non-Windows. (Closed)

Created:
10 years, 10 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., jam, jam+cc_chromium.org

Visibility:
Public.

Description

Deprecate file_util::AppendToPath() on non-Windows. We still have ~150 callers to AppendToPath in our code, but most of them are in the installer and I'm reluctant to fiddle with that code without having an easy way to test it. BUG=24672 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40120

Patch Set 1 #

Patch Set 2 : ok #

Patch Set 3 : fix unit_tests #

Patch Set 4 : rebase #

Total comments: 2

Patch Set 5 : ok #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -27 lines)			Patch
M	base/file_util.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	base/file_util.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	base/file_util_deprecated.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	base/file_util_unittest.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_plugin_host.cc	View	1 2 3 4	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/user_data_manager.cc	View	1 2 3	5 chunks	+11 lines, -6 lines	0 comments	Download
M	chrome/common/chrome_constants.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_constants.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/plugin/chrome_plugin_host.cc	View	1 2 3 4	1 chunk	+7 lines, -5 lines	0 comments	Download
M	printing/printed_document.cc	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

lgtm.. if you run try with .grd changes you need to specify --clobber On 2010/02/25 ...

10 years, 10 months ago (2010-02-25 12:56:43 UTC) #2

jochen (gone - plz use gerrit)

10 years, 10 months ago (2010-02-25 12:57:01 UTC) #3

ehrm. and here are my coments :)

http://codereview.chromium.org/654013/diff/3001/3007
File chrome/browser/chrome_plugin_host.cc (right):

http://codereview.chromium.org/654013/diff/3001/3007#newcode466
chrome/browser/chrome_plugin_host.cc:466:
path.AppendASCII(chrome::kChromePluginDataDirname).ToWStringHack());
FilePath really should have a utf8() and a utf16() method :(

http://codereview.chromium.org/654013/diff/3001/3010
File chrome/common/chrome_constants.h (right):

http://codereview.chromium.org/654013/diff/3001/3010#newcode43
chrome/common/chrome_constants.h:43: extern const char
kChromePluginDataDirname[];
why not FilePath::CharType?

Expand Messages | Collapse Messages