CHROMIUM: Add gobi driver.

CHROMIUM: Add gobi driver.

(It isn't built yet, so this should have no functional changes at all).

BUG=chromium-os:5521
TEST=suite_Cellular

Change-Id: I28bc550bd600ba350f8b34926e698bbb2b3c8c6c
Signed-off-by: Elly Jones <ellyjones@chromium.org>;
Signed-off-by: Jason Glasgow <jglasgow@chromium.org>;
Signed-off-by: Olof Johansson <olofj@chromium.org>;

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7e33652

[Elly Fong-Jones, 2011-02-23 15:26:58]

On 2011/02/17 18:16:33, Elly Jones wrote:

Beep?

[Mandeep Singh Baines, 2011-02-23 16:51:55]

Don't make config and code changes in the same CL.

Shouldn't this go into for kernel-next? kernel.git is in maintenance
mode.

ellyjones@chromium.org (ellyjones@chromium.org) wrote:
> Reviewers: Jason Glasgow, Mandeep Singh Baines,
> 
> Description:
> Add gobi driver.
> 
> (It isn't built yet, so this should have no functional changes at all).
> 
> BUG=chromium-os:5521
> TEST=suite_Cellular
> 
> Change-Id: I28bc550bd600ba350f8b34926e698bbb2b3c8c6c
> Signed-off-by: Elly Jones <ellyjones@chromium.org>
> 
> Please review this at http://codereview.chromium.org/6539018/
> 
> SVN Base: ssh://git@gitrw.chromium.org:9222/kernel.git@master
> 
> Affected files:
>   M chromeos/config/i386/config.common.i386
>   M drivers/net/usb/Kconfig
>   M drivers/net/usb/Makefile
>   A drivers/net/usb/gobi/Makefile
>   A drivers/net/usb/gobi/README
>   A drivers/net/usb/gobi/qcusbnet.h
>   A drivers/net/usb/gobi/qcusbnet.c
>   A drivers/net/usb/gobi/qmi.h
>   A drivers/net/usb/gobi/qmi.c
>   A drivers/net/usb/gobi/qmidevice.h
>   A drivers/net/usb/gobi/qmidevice.c
>   A drivers/net/usb/gobi/structs.h
> 
> 

[Elly Fong-Jones, 2011-02-23 18:46:08]

This change adds only the disabled config option (i.e., "# CONFIG_USB_NET_GOBI
is not set"). Is that still unsafe?

On 2011/02/23 16:51:55, Mandeep Singh Baines wrote:
> Don't make config and code changes in the same CL.
> 
> Shouldn't this go into for kernel-next? kernel.git is in maintenance
> mode.
> 
> mailto:ellyjones@chromium.org (mailto:ellyjones@chromium.org) wrote:
> > Reviewers: Jason Glasgow, Mandeep Singh Baines,
> > 
> > Description:
> > Add gobi driver.
> > 
> > (It isn't built yet, so this should have no functional changes at all).
> > 
> > BUG=chromium-os:5521
> > TEST=suite_Cellular
> > 
> > Change-Id: I28bc550bd600ba350f8b34926e698bbb2b3c8c6c
> > Signed-off-by: Elly Jones <mailto:ellyjones@chromium.org>
> > 
> > Please review this at http://codereview.chromium.org/6539018/
> > 
> > SVN Base: ssh://git@gitrw.chromium.org:9222/kernel.git@master
> > 
> > Affected files:
> >   M chromeos/config/i386/config.common.i386
> >   M drivers/net/usb/Kconfig
> >   M drivers/net/usb/Makefile
> >   A drivers/net/usb/gobi/Makefile
> >   A drivers/net/usb/gobi/README
> >   A drivers/net/usb/gobi/qcusbnet.h
> >   A drivers/net/usb/gobi/qcusbnet.c
> >   A drivers/net/usb/gobi/qmi.h
> >   A drivers/net/usb/gobi/qmi.c
> >   A drivers/net/usb/gobi/qmidevice.h
> >   A drivers/net/usb/gobi/qmidevice.c
> >   A drivers/net/usb/gobi/structs.h
> > 
> >

[Olof Johansson, 2011-02-23 19:46:47]

The main to do them separately is because we rebase config files
separately from code changes, so if there's a config changed mixed
with regular changes it makes life harder for us to maintain.

But, as Mandeep said: kernel.git is mostly in maintenance mode. Is
there a good reason to pick this up there instead of just focus on it
in kernel-next instead?


-Olof

On Wed, Feb 23, 2011 at 10:46 AM,  <ellyjones@chromium.org> wrote:
> This change adds only the disabled config option (i.e., "#
> CONFIG_USB_NET_GOBI
> is not set"). Is that still unsafe?
>
> On 2011/02/23 16:51:55, Mandeep Singh Baines wrote:
>>
>> Don't make config and code changes in the same CL.
>
>> Shouldn't this go into for kernel-next? kernel.git is in maintenance
>> mode.
>
>> mailto:ellyjones@chromium.org (mailto:ellyjones@chromium.org) wrote:
>> > Reviewers: Jason Glasgow, Mandeep Singh Baines,
>> >
>> > Description:
>> > Add gobi driver.
>> >
>> > (It isn't built yet, so this should have no functional changes at all).
>> >
>> > BUG=chromium-os:5521
>> > TEST=suite_Cellular
>> >
>> > Change-Id: I28bc550bd600ba350f8b34926e698bbb2b3c8c6c
>> > Signed-off-by: Elly Jones <mailto:ellyjones@chromium.org>
>> >
>> > Please review this at http://codereview.chromium.org/6539018/
>> >
>> > SVN Base: ssh://git@gitrw.chromium.org:9222/kernel.git@master
>> >
>> > Affected files:
>> >   M chromeos/config/i386/config.common.i386
>> >   M drivers/net/usb/Kconfig
>> >   M drivers/net/usb/Makefile
>> >   A drivers/net/usb/gobi/Makefile
>> >   A drivers/net/usb/gobi/README
>> >   A drivers/net/usb/gobi/qcusbnet.h
>> >   A drivers/net/usb/gobi/qcusbnet.c
>> >   A drivers/net/usb/gobi/qmi.h
>> >   A drivers/net/usb/gobi/qmi.c
>> >   A drivers/net/usb/gobi/qmidevice.h
>> >   A drivers/net/usb/gobi/qmidevice.c
>> >   A drivers/net/usb/gobi/structs.h
>> >
>> >
>
>
>
> http://codereview.chromium.org/6539018/
>

[Olof Johansson, 2011-03-08 20:38:15]

Hi,

1) Please separate out config update to a separate CL, even though it's trivial
2) Please prefix commit message (first like in description) with CHROMIUM:
3) This should go upstream as soon as practical. I know it's hung up on some
userspace dependencies now, please continue to work on getting those resolved so
we can stop carrying this locally.


Thanks,

-Olof

[Olof Johansson, 2011-03-08 22:36:30]

LGTM

[jglasgow, 2011-03-09 14:22:47]

LGTM