Issue 6539017: Initialize media library on service process startup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6539017: Initialize media library on service process startup. (Closed)

Created:
9 years, 10 months ago by Wez

Modified:
9 years, 7 months ago

Reviewers:
awong, Alpha Left Google

CC:
chromium-reviews

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Initialize media library on service process startup. BUG=73166 TEST=Enable Chromoting Host in Chrome, and try to connect to it. The service process should not crash trying to retrieve the VP8 codec. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75379

Patch Set 1 #

Total comments: 3

Patch Set 2 : Pick hclam's nits. #

Patch Set 3 : Add missing include under Mac OS X #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -5 lines)			Patch
	M	chrome/service/DEPS	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
	M	chrome/service/service_process.cc	View	1 2	4 chunks	+23 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Wez

Quick fix adding the missing media library initialization to the service process.

9 years, 10 months ago (2011-02-17 17:04:50 UTC) #1

Alpha Left Google

9 years, 10 months ago (2011-02-17 17:23:10 UTC) #2

http://codereview.chromium.org/6539017/diff/1/chrome/service/DEPS
File chrome/service/DEPS (right):

http://codereview.chromium.org/6539017/diff/1/chrome/service/DEPS#newcode3
chrome/service/DEPS:3: # For Media initialization def
nit: definition

http://codereview.chromium.org/6539017/diff/1/chrome/service/service_process.cc
File chrome/service/service_process.cc (right):

http://codereview.chromium.org/6539017/diff/1/chrome/service/service_process....
chrome/service/service_process.cc:242: if (remoting_host_manager_.get())
nit: since the following statement span across two lines, please use {} to
enclose it.

http://codereview.chromium.org/6539017/diff/1/chrome/service/service_process....
chrome/service/service_process.cc:244: NewRunnableFunction(&QuitMessageLoop,
main_message_loop_));
nit: indent this by 4 spaces.

Expand Messages | Collapse Messages