Issue 6539013: views: Do not show up a tooltip when hovering on the magnifying glass on NTP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6539013: views: Do not show up a tooltip when hovering on the magnifying glass on NTP. (Closed)

Created:
9 years, 10 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Finnur

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

views: Do not show up a tooltip when hovering on the magnifying glass on NTP. BUG=73252 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75323

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -1 line)			Patch
M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_icon_view.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_icon_view.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Finnur

9 years, 10 months ago (2011-02-17 13:32:52 UTC) #2

LGTM & tested it locally.

Didn't Glen suggest to remove the 'Click to' prefix from tooltip?

If so, maybe do that as part of this CL and check in.

On 2011/02/17 12:58:07, tfarina wrote:
> Hi Finnur, could you review this to me?

Expand Messages | Collapse Messages