Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 6539006: Autodetect no-strict-aliasing, propagate toolchain option to SCons (Closed)

Created:
9 years, 10 months ago by piscisaureus
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Autodetect no-strict-aliasing, propagate toolchain option to SCons Patch by Bert Belder. BUG=v8:884 Committed: http://code.google.com/p/v8/source/detail?r=7449

Patch Set 1 #

Patch Set 2 : Minor fix, rebased #

Total comments: 2

Patch Set 3 : Updated patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -36 lines) Patch
M SConstruct View 1 2 15 chunks +96 lines, -35 lines 0 comments Download
M src/SConscript View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
piscisaureus
- Compiling with GCC 4.5.x produces a nonfunctional v8; this is fixed by checking for ...
9 years, 10 months ago (2011-02-17 04:00:32 UTC) #1
piscisaureus
Minor fix to detect gcc 4.5.0, for which `gcc -dumpversion` apparently reports just '4.5'. Rebased ...
9 years, 9 months ago (2011-03-16 10:38:51 UTC) #2
Vyacheslav Egorov (Chromium)
http://codereview.chromium.org/6539006/diff/2001/SConstruct File SConstruct (right): http://codereview.chromium.org/6539006/diff/2001/SConstruct#newcode696 SConstruct:696: version = subprocess.Popen([env['CC'], '-dumpversion'], should not we just rely ...
9 years, 9 months ago (2011-03-29 11:59:33 UTC) #3
piscisaureus
- Split up the options list instead of adding dependency resolution. - Added a comment ...
9 years, 9 months ago (2011-03-29 15:50:40 UTC) #4
piscisaureus
9 years, 9 months ago (2011-03-29 15:51:06 UTC) #5
Vyacheslav Egorov (Chromium)
9 years, 8 months ago (2011-03-30 17:18:24 UTC) #6
LGTM,

will land.

Thanks for fixing this Bert!

Powered by Google App Engine
This is Rietveld 408576698