Issue 6538104: Causing gyp_chromium to fall back on win32 hermetic python if it is...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6538104: Causing gyp_chromium to fall back on win32 hermetic python if it is... (Closed)

Created:
9 years, 10 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting, Use pkasting(at)chromium.org

CC:
chromium-reviews

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Causing gyp_chromium to fall back on win32 hermetic python if it is ever run with cygwin python. BUG=http://code.google.com/p/gyp/issues/detail?id=178 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75695

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	build/gyp_chromium	View	1 2	2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

Rubber-stamp LGTM http://codereview.chromium.org/6538104/diff/1/build/gyp_chromium File build/gyp_chromium (right): http://codereview.chromium.org/6538104/diff/1/build/gyp_chromium#newcode82 build/gyp_chromium:82: # Fall back on hermetic python if ...

9 years, 10 months ago (2011-02-23 00:04:49 UTC) #2

bradn

9 years, 10 months ago (2011-02-23 01:43:13 UTC) #3

Added and will commit shortly.
-BradN


On Tue, Feb 22, 2011 at 4:04 PM, <pkasting@chromium.org> wrote:

> Rubber-stamp LGTM
>
>
> http://codereview.chromium.org/6538104/diff/1/build/gyp_chromium
> File build/gyp_chromium (right):
>
> http://codereview.chromium.org/6538104/diff/1/build/gyp_chromium#newcode82
> build/gyp_chromium:82: # Fall back on hermetic python if we happen to
> get run under cygwin.
> Nit: Do you want to TODO this with the bug about making gyp work with
> cygwin python?
>
>
> http://codereview.chromium.org/6538104/
>

Expand Messages | Collapse Messages