Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/child_process_security_policy_unittest.cc

Issue 6538100: Move core pieces of chrome\browser. I've only gone up to "g", will do the re... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: take out extra stuff from content_browser.gypi Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/child_process_security_policy_browsertest.cc ('k') | chrome/browser/chrome_blob_storage_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/child_process_security_policy_unittest.cc
===================================================================
--- chrome/browser/child_process_security_policy_unittest.cc (revision 75626)
+++ chrome/browser/child_process_security_policy_unittest.cc (working copy)
@@ -1,333 +0,0 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include <string>
-
-#include "base/basictypes.h"
-#include "base/file_path.h"
-#include "base/platform_file.h"
-#include "chrome/browser/child_process_security_policy.h"
-#include "chrome/common/url_constants.h"
-#include "net/url_request/url_request.h"
-#include "net/url_request/url_request_test_job.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-class ChildProcessSecurityPolicyTest : public testing::Test {
- protected:
- // testing::Test
- virtual void SetUp() {
- // In the real world, "chrome:" is a handled scheme.
- net::URLRequest::RegisterProtocolFactory(chrome::kChromeUIScheme,
- &net::URLRequestTestJob::Factory);
- }
- virtual void TearDown() {
- net::URLRequest::RegisterProtocolFactory(chrome::kChromeUIScheme, NULL);
- }
-};
-
-static int kRendererID = 42;
-
-TEST_F(ChildProcessSecurityPolicyTest, IsWebSafeSchemeTest) {
- ChildProcessSecurityPolicy* p = ChildProcessSecurityPolicy::GetInstance();
-
- EXPECT_TRUE(p->IsWebSafeScheme(chrome::kHttpScheme));
- EXPECT_TRUE(p->IsWebSafeScheme(chrome::kHttpsScheme));
- EXPECT_TRUE(p->IsWebSafeScheme(chrome::kFtpScheme));
- EXPECT_TRUE(p->IsWebSafeScheme(chrome::kDataScheme));
- EXPECT_TRUE(p->IsWebSafeScheme("feed"));
- EXPECT_TRUE(p->IsWebSafeScheme(chrome::kExtensionScheme));
-
- EXPECT_FALSE(p->IsWebSafeScheme("registered-web-safe-scheme"));
- p->RegisterWebSafeScheme("registered-web-safe-scheme");
- EXPECT_TRUE(p->IsWebSafeScheme("registered-web-safe-scheme"));
-}
-
-TEST_F(ChildProcessSecurityPolicyTest, IsPseudoSchemeTest) {
- ChildProcessSecurityPolicy* p = ChildProcessSecurityPolicy::GetInstance();
-
- EXPECT_TRUE(p->IsPseudoScheme(chrome::kAboutScheme));
- EXPECT_TRUE(p->IsPseudoScheme(chrome::kJavaScriptScheme));
- EXPECT_TRUE(p->IsPseudoScheme(chrome::kViewSourceScheme));
-
- EXPECT_FALSE(p->IsPseudoScheme("registered-psuedo-scheme"));
- p->RegisterPseudoScheme("registered-psuedo-scheme");
- EXPECT_TRUE(p->IsPseudoScheme("registered-psuedo-scheme"));
-}
-
-TEST_F(ChildProcessSecurityPolicyTest, StandardSchemesTest) {
- ChildProcessSecurityPolicy* p = ChildProcessSecurityPolicy::GetInstance();
-
- p->Add(kRendererID);
-
- // Safe
- EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("http://www.google.com/")));
- EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("https://www.paypal.com/")));
- EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("ftp://ftp.gnu.org/")));
- EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("data:text/html,<b>Hi</b>")));
- EXPECT_TRUE(p->CanRequestURL(kRendererID,
- GURL("view-source:http://www.google.com/")));
- EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("chrome-extension://xy/z")));
-
- // Dangerous
- EXPECT_FALSE(p->CanRequestURL(kRendererID,
- GURL("file:///etc/passwd")));
- EXPECT_FALSE(p->CanRequestURL(kRendererID,
- GURL("chrome://foo/bar")));
-
- p->Remove(kRendererID);
-}
-
-TEST_F(ChildProcessSecurityPolicyTest, AboutTest) {
- ChildProcessSecurityPolicy* p = ChildProcessSecurityPolicy::GetInstance();
-
- p->Add(kRendererID);
-
- EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("about:blank")));
- EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("about:BlAnK")));
- EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("aBouT:BlAnK")));
- EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("aBouT:blank")));
-
- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:memory")));
- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:crash")));
- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:cache")));
- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:hang")));
-
- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("aBoUt:memory")));
- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("about:CrASh")));
- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("abOuT:cAChe")));
-
- p->GrantRequestURL(kRendererID, GURL(chrome::kAboutMemoryURL));
- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL(chrome::kAboutMemoryURL)));
-
- p->GrantRequestURL(kRendererID, GURL(chrome::kAboutCrashURL));
- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL(chrome::kAboutCrashURL)));
-
- p->GrantRequestURL(kRendererID, GURL(chrome::kAboutCacheURL));
- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL(chrome::kAboutCacheURL)));
-
- p->GrantRequestURL(kRendererID, GURL(chrome::kAboutHangURL));
- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL(chrome::kAboutHangURL)));
-
- p->Remove(kRendererID);
-}
-
-TEST_F(ChildProcessSecurityPolicyTest, JavaScriptTest) {
- ChildProcessSecurityPolicy* p = ChildProcessSecurityPolicy::GetInstance();
-
- p->Add(kRendererID);
-
- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("javascript:alert('xss')")));
- p->GrantRequestURL(kRendererID, GURL("javascript:alert('xss')"));
- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("javascript:alert('xss')")));
-
- p->Remove(kRendererID);
-}
-
-TEST_F(ChildProcessSecurityPolicyTest, RegisterWebSafeSchemeTest) {
- ChildProcessSecurityPolicy* p = ChildProcessSecurityPolicy::GetInstance();
-
- p->Add(kRendererID);
-
- // Currently, "asdf" is destined for ShellExecute, so it is allowed.
- EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("asdf:rockers")));
-
- // Once we register a ProtocolFactory for "asdf", we default to deny.
- net::URLRequest::RegisterProtocolFactory("asdf",
- &net::URLRequestTestJob::Factory);
- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("asdf:rockers")));
-
- // We can allow new schemes by adding them to the whitelist.
- p->RegisterWebSafeScheme("asdf");
- EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("asdf:rockers")));
-
- // Cleanup.
- net::URLRequest::RegisterProtocolFactory("asdf", NULL);
- EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("asdf:rockers")));
-
- p->Remove(kRendererID);
-}
-
-TEST_F(ChildProcessSecurityPolicyTest, CanServiceCommandsTest) {
- ChildProcessSecurityPolicy* p = ChildProcessSecurityPolicy::GetInstance();
-
- p->Add(kRendererID);
-
- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("file:///etc/passwd")));
- p->GrantRequestURL(kRendererID, GURL("file:///etc/passwd"));
- EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("file:///etc/passwd")));
-
- // We should forget our state if we repeat a renderer id.
- p->Remove(kRendererID);
- p->Add(kRendererID);
- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("file:///etc/passwd")));
- p->Remove(kRendererID);
-}
-
-TEST_F(ChildProcessSecurityPolicyTest, ViewSource) {
- ChildProcessSecurityPolicy* p = ChildProcessSecurityPolicy::GetInstance();
-
- p->Add(kRendererID);
-
- // View source is determined by the embedded scheme.
- EXPECT_TRUE(p->CanRequestURL(kRendererID,
- GURL("view-source:http://www.google.com/")));
- EXPECT_FALSE(p->CanRequestURL(kRendererID,
- GURL("view-source:file:///etc/passwd")));
- EXPECT_FALSE(p->CanRequestURL(kRendererID, GURL("file:///etc/passwd")));
- EXPECT_FALSE(p->CanRequestURL(
- kRendererID, GURL("view-source:view-source:http://www.google.com/")));
-
- p->GrantRequestURL(kRendererID, GURL("view-source:file:///etc/passwd"));
- // View source needs to be able to request the embedded scheme.
- EXPECT_TRUE(p->CanRequestURL(kRendererID,
- GURL("view-source:file:///etc/passwd")));
- EXPECT_TRUE(p->CanRequestURL(kRendererID, GURL("file:///etc/passwd")));
-
- p->Remove(kRendererID);
-}
-
-TEST_F(ChildProcessSecurityPolicyTest, CanReadFiles) {
- ChildProcessSecurityPolicy* p = ChildProcessSecurityPolicy::GetInstance();
-
- p->Add(kRendererID);
-
- EXPECT_FALSE(p->CanReadFile(kRendererID,
- FilePath(FILE_PATH_LITERAL("/etc/passwd"))));
- p->GrantReadFile(kRendererID, FilePath(FILE_PATH_LITERAL("/etc/passwd")));
- EXPECT_TRUE(p->CanReadFile(kRendererID,
- FilePath(FILE_PATH_LITERAL("/etc/passwd"))));
- EXPECT_FALSE(p->CanReadFile(kRendererID,
- FilePath(FILE_PATH_LITERAL("/etc/shadow"))));
-
- p->Remove(kRendererID);
- p->Add(kRendererID);
-
- EXPECT_FALSE(p->CanReadFile(kRendererID,
- FilePath(FILE_PATH_LITERAL("/etc/passwd"))));
- EXPECT_FALSE(p->CanReadFile(kRendererID,
- FilePath(FILE_PATH_LITERAL("/etc/shadow"))));
-
- p->Remove(kRendererID);
-}
-
-TEST_F(ChildProcessSecurityPolicyTest, FilePermissions) {
- ChildProcessSecurityPolicy* p = ChildProcessSecurityPolicy::GetInstance();
-
- // Grant permissions for a file.
- p->Add(kRendererID);
- FilePath file = FilePath(FILE_PATH_LITERAL("/etc/passwd"));
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
- base::PLATFORM_FILE_OPEN));
-
- p->GrantPermissionsForFile(kRendererID, file,
- base::PLATFORM_FILE_OPEN |
- base::PLATFORM_FILE_READ |
- base::PLATFORM_FILE_WRITE |
- base::PLATFORM_FILE_TRUNCATE);
- EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, file,
- base::PLATFORM_FILE_OPEN |
- base::PLATFORM_FILE_READ |
- base::PLATFORM_FILE_WRITE |
- base::PLATFORM_FILE_TRUNCATE));
- EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, file,
- base::PLATFORM_FILE_OPEN |
- base::PLATFORM_FILE_READ));
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
- base::PLATFORM_FILE_CREATE));
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
- base::PLATFORM_FILE_CREATE |
- base::PLATFORM_FILE_READ |
- base::PLATFORM_FILE_WRITE |
- base::PLATFORM_FILE_TRUNCATE));
- p->Remove(kRendererID);
-
- // Grant permissions for the directory the file is in.
- p->Add(kRendererID);
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
- base::PLATFORM_FILE_OPEN));
- p->GrantPermissionsForFile(kRendererID, FilePath(FILE_PATH_LITERAL("/etc")),
- base::PLATFORM_FILE_OPEN |
- base::PLATFORM_FILE_READ);
- EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, file,
- base::PLATFORM_FILE_OPEN));
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
- base::PLATFORM_FILE_READ |
- base::PLATFORM_FILE_WRITE));
- p->Remove(kRendererID);
-
- // Grant permissions for the directory the file is in (with trailing '/').
- p->Add(kRendererID);
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
- base::PLATFORM_FILE_OPEN));
- p->GrantPermissionsForFile(kRendererID, FilePath(FILE_PATH_LITERAL("/etc/")),
- base::PLATFORM_FILE_OPEN |
- base::PLATFORM_FILE_READ);
- EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, file,
- base::PLATFORM_FILE_OPEN));
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
- base::PLATFORM_FILE_READ |
- base::PLATFORM_FILE_WRITE));
-
- // Grant permissions for the file (should overwrite the permissions granted
- // for the directory).
- p->GrantPermissionsForFile(kRendererID, file, base::PLATFORM_FILE_TEMPORARY);
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
- base::PLATFORM_FILE_OPEN));
- EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, file,
- base::PLATFORM_FILE_TEMPORARY));
-
- // Revoke all permissions for the file (it should inherit its permissions
- // from the directory again).
- p->RevokeAllPermissionsForFile(kRendererID, file);
- EXPECT_TRUE(p->HasPermissionsForFile(kRendererID, file,
- base::PLATFORM_FILE_OPEN |
- base::PLATFORM_FILE_READ));
- EXPECT_FALSE(p->HasPermissionsForFile(kRendererID, file,
- base::PLATFORM_FILE_TEMPORARY));
- p->Remove(kRendererID);
-}
-
-TEST_F(ChildProcessSecurityPolicyTest, CanServiceWebUIBindings) {
- ChildProcessSecurityPolicy* p = ChildProcessSecurityPolicy::GetInstance();
-
- GURL url("chrome://thumb/http://www.google.com/");
-
- p->Add(kRendererID);
-
- EXPECT_FALSE(p->HasWebUIBindings(kRendererID));
- EXPECT_FALSE(p->CanRequestURL(kRendererID, url));
- p->GrantWebUIBindings(kRendererID);
- EXPECT_TRUE(p->HasWebUIBindings(kRendererID));
- EXPECT_TRUE(p->CanRequestURL(kRendererID, url));
-
- p->Remove(kRendererID);
-}
-
-TEST_F(ChildProcessSecurityPolicyTest, RemoveRace) {
- ChildProcessSecurityPolicy* p = ChildProcessSecurityPolicy::GetInstance();
-
- GURL url("file:///etc/passwd");
- FilePath file(FILE_PATH_LITERAL("/etc/passwd"));
-
- p->Add(kRendererID);
-
- p->GrantRequestURL(kRendererID, url);
- p->GrantReadFile(kRendererID, file);
- p->GrantWebUIBindings(kRendererID);
-
- EXPECT_TRUE(p->CanRequestURL(kRendererID, url));
- EXPECT_TRUE(p->CanReadFile(kRendererID, file));
- EXPECT_TRUE(p->HasWebUIBindings(kRendererID));
-
- p->Remove(kRendererID);
-
- // Renderers are added and removed on the UI thread, but the policy can be
- // queried on the IO thread. The ChildProcessSecurityPolicy needs to be
- // prepared to answer policy questions about renderers who no longer exist.
-
- // In this case, we default to secure behavior.
- EXPECT_FALSE(p->CanRequestURL(kRendererID, url));
- EXPECT_FALSE(p->CanReadFile(kRendererID, file));
- EXPECT_FALSE(p->HasWebUIBindings(kRendererID));
-}
« no previous file with comments | « chrome/browser/child_process_security_policy_browsertest.cc ('k') | chrome/browser/chrome_blob_storage_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698