Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issue 6538098: [Chrome OS] Owner keys are generated outside Chrome now; handle appropriately (Closed)

Created:
9 years, 10 months ago by Chris Masone
Modified:
9 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

[Chrome OS] Owner keys are generated outside Chrome now; handle appropriately Generation of the Owner's key pair is now handled by the session_manager. Remove all the logic for key generation from Chrome, and instead add in logic to always send a notification when we get the signal that key generation has completed The session_manager side of the change is at http://codereview.chromium.org/6469072/ BUG=chromium-os:9608 TEST=unit tests, install on device and run OwnershipTaken and OwnershipNotRetaken and see they pass. Also, log in to a fresh install and see that owner settings become available. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -322 lines) Patch
M chrome/browser/chromeos/cros/login_library.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/cros/login_library.cc View 4 chunks +22 lines, -24 lines 0 comments Download
M chrome/browser/chromeos/cros/mock_login_library.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/mock_owner_key_utils.h View 2 chunks +2 lines, -28 lines 0 comments Download
M chrome/browser/chromeos/login/mock_ownership_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/owner_key_utils.h View 4 chunks +11 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/login/owner_key_utils.cc View 3 chunks +2 lines, -35 lines 0 comments Download
M chrome/browser/chromeos/login/owner_key_utils_unittest.cc View 1 chunk +9 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/owner_manager.h View 3 chunks +1 line, -18 lines 0 comments Download
M chrome/browser/chromeos/login/owner_manager.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M chrome/browser/chromeos/login/owner_manager_unittest.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M chrome/browser/chromeos/login/ownership_service.h View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/ownership_service.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/login/ownership_service_unittest.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Chris Masone
PTAL. A lot of the changes are deletion :-)
9 years, 10 months ago (2011-02-22 22:08:03 UTC) #1
Chris Masone
Ping? On Tuesday, February 22, 2011, <cmasone@chromium.org> wrote: > Reviewers: Nikita Kostylev, > > Message: ...
9 years, 10 months ago (2011-02-24 16:43:54 UTC) #2
Nikita (slow)
9 years, 10 months ago (2011-02-24 18:01:34 UTC) #3
LGTM
Sorry for delay.

Powered by Google App Engine
This is Rietveld 408576698