Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 6538088: Fix bug with input representation of HValueOf.... (Closed)

Created:
9 years, 10 months ago by fschneider
Modified:
9 years, 6 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Fix bug with input representation of HValueOf. The class did not correctly implement the RequiredInputRepresentation. I changed this functions to be abstract so that all hydrogen classes must implement it. As a convention instructions with zero input operands return None as input representation. Instructions that can handle all input representations without converting before also have None as required input representation (e.g. HTest) All other instructions need a proper required input representation. Committed: http://code.google.com/p/v8/source/detail?r=6891

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -12 lines) Patch
M src/hydrogen-instructions.h View 40 chunks +148 lines, -12 lines 0 comments Download
A test/mjsunit/compiler/regress-valueof.js View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years, 10 months ago (2011-02-22 12:01:42 UTC) #1
William Hesse
9 years, 10 months ago (2011-02-22 12:10:22 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698