Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 6538084: Remove dependency on get-text, gtk2 and gconf2 (Closed)

Created:
9 years, 10 months ago by Zachary Kuznia
Modified:
9 years, 7 months ago
Reviewers:
Yusuke Sato, satorux1
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Remove dependency on get-text, gtk2 and gconf2. Change-Id: I1f796502e44e052304bd5379e5872a42e911733c BUG=chromium-os:12350 TEST=None Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7a9514a

Patch Set 1 #

Patch Set 2 : Code review #

Total comments: 4

Patch Set 3 : Code review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -12 lines) Patch
M src/CMakeLists.txt View 1 3 chunks +15 lines, -8 lines 0 comments Download
M src/IBusChewingEngine.gob View 1 1 chunk +43 lines, -1 line 0 comments Download
M src/main.c View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Zachary Kuznia
9 years, 10 months ago (2011-02-25 01:31:20 UTC) #1
satorux1
http://codereview.chromium.org/6538084/diff/2001/SPECS/ibus-chewing.spec.in File SPECS/ibus-chewing.spec.in (right): http://codereview.chromium.org/6538084/diff/2001/SPECS/ibus-chewing.spec.in#newcode13 SPECS/ibus-chewing.spec.in:13: #BuildRequires: gettext-devel I think this file isn't used for ...
9 years, 10 months ago (2011-02-25 01:54:47 UTC) #2
Zachary Kuznia
http://codereview.chromium.org/6538084/diff/2001/SPECS/ibus-chewing.spec.in File SPECS/ibus-chewing.spec.in (right): http://codereview.chromium.org/6538084/diff/2001/SPECS/ibus-chewing.spec.in#newcode13 SPECS/ibus-chewing.spec.in:13: #BuildRequires: gettext-devel On 2011/02/25 01:54:47, satorux1 wrote: > I ...
9 years, 10 months ago (2011-02-25 02:04:29 UTC) #3
satorux1
LGTM
9 years, 10 months ago (2011-02-25 02:13:19 UTC) #4
Yusuke Sato
9 years, 10 months ago (2011-02-25 02:20:42 UTC) #5
Thanks Zach!

On Fri, Feb 25, 2011 at 10:13 AM, <satorux@chromium.org> wrote:

> LGTM
>
>
> http://codereview.chromium.org/6538084/
>

Powered by Google App Engine
This is Rietveld 408576698