Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 6538081: Properly reset external catcher if exception couldn't be externally caught. (Closed)

Created:
9 years, 10 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Properly reset external catcher if exception couldn't be externally caught. We can wrongly assume that exception which is not intended to be caught by external try/catch should be caught if this exception inherits external catcher from some previous exception. To prevent that, clear external catcher when processing exceptions which cannot be externally caught. BUG=v8:1184 TEST=test/mjsunit/regress/regress-1184.js Committed: http://code.google.com/p/v8/source/detail?r=6905

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -6 lines) Patch
M src/top.cc View 2 chunks +6 lines, -6 lines 0 comments Download
A test/mjsunit/regress/regress-1184.js View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
Mads, another exception handling related review for you.
9 years, 10 months ago (2011-02-21 20:54:03 UTC) #1
Mads Ager (chromium)
9 years, 10 months ago (2011-02-22 08:30:15 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698