Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 6538061: Removing AccessLog class. This is a partial revert of yzshen's r74872. (Closed)

Created:
9 years, 10 months ago by Jói
Modified:
9 years, 7 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Removing AccessLog class. This is a partial revert of yzshen's r74872. The AccessLog class was something we added to track down a crash, which is no longer happening after that change. Reverting piece by piece and waiting for the next canary build before doing the next part. Note that the use of the AccessLog class could have introduced slight serialization to the method URLRequestThrottlerManager::RegisterRequestUrl as it would call the AccessLog::Add method which synchronized on a lock. So removing is not 100% safe; I will watch for crashes in the canary builds after this. BUG=71721 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75438

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -69 lines) Patch
M net/url_request/url_request_throttler_manager.h View 1 chunk +0 lines, -6 lines 0 comments Download
M net/url_request/url_request_throttler_manager.cc View 4 chunks +1 line, -63 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jói
9 years, 10 months ago (2011-02-18 20:24:48 UTC) #1
yzshen1
9 years, 10 months ago (2011-02-18 20:58:07 UTC) #2
LGTM

Thanks Joi!

Powered by Google App Engine
This is Rietveld 408576698