Issue 6538055: Patch drover to work with svn clients that don't provide a revision number

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6538055: Patch drover to work with svn clients that don't provide a revision number (Closed)

Created:
9 years, 10 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
laforge

CC:
chromium-reviews, M-A Ruel

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools/

Visibility:
Public.

Description

I am a huge fan of drover, but discovered this morning that it wasn't working with my svn client, even though it was version 1.6.15. I did some poking around, and found that because SlikSvn doesn't give a revision number in its --version information dump, it was failing to match the regex in drover.py. I then noticed that the revision number wasn't being used for anything, so I removed it and everything worked great again. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75398

Patch Set 1 #

Patch Set 2 : from committable repository #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	drover.py	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Lgtm

Expand Messages | Collapse Messages