Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 6538049: For webkit_glue::MockWebFrame, define setScrollOffset() that will be soon introduced. (Closed)

Created:
9 years, 10 months ago by Yuzo
Modified:
9 years, 7 months ago
Reviewers:
hamaji
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

For webkit_glue::MockWebFrame, define setScrollOffset() that will be soon introduced. (by https://bugs.webkit.org/show_bug.cgi?id=54632). Otherwise, landing the WebKit patch results in Chromium build breakage. Example: .\glue\media\buffered_resource_loader_unittest.cc(87) : error C2259: 'testing::NiceMock<MockClass>' : cannot instantiate abstract class with [ MockClass=webkit_glue::MockWebFrame ] due to following members: 'void WebKit::WebFrame::setScrollOffset(const WebKit::WebSize &)' : is abstract c:\b\build\slave\webkit-win-latest-rel\build\src\third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h(146) : see declaration of 'WebKit::WebFrame::setScrollOffset' BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75367

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webkit/mocks/mock_webframe.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/mocks/mock_webframe.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yuzo
Hamaji-san, can you review this? I need to commit the patches in the following order: ...
9 years, 10 months ago (2011-02-18 05:04:57 UTC) #1
hamaji
9 years, 10 months ago (2011-02-18 06:28:41 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698