Issue 6538047: [Sync] Clean up about:sync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6538047: [Sync] Clean up about:sync (Closed)

Created:
9 years, 10 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
John Gregg

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Sync] Clean up about:sync Converted from table-based layout to CSS positioning. Cleaned up markup and styles. Fixed some bugs in chrome_sync.js. This is in preparation for putting the top-level divs in a tabbed view. BUG=69500 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75463

Patch Set 1 #

Patch Set 2 : Fix HTML errors #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -211 lines)			Patch
D	chrome/browser/resources/sync_internals/about.css	View		1 chunk	+0 lines, -105 lines	0 comments	Download
M	chrome/browser/resources/sync_internals/about.html	View	1	1 chunk	+66 lines, -69 lines	0 comments	Download
M	chrome/browser/resources/sync_internals/chrome_sync.js	View		2 chunks	+11 lines, -7 lines	0 comments	Download
M	chrome/browser/resources/sync_internals/notifications.html	View	1	1 chunk	+9 lines, -10 lines	0 comments	Download
M	chrome/browser/resources/sync_internals/sync_index.html	View		1 chunk	+29 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/sync_internals/sync_node_browser.html	View	1	2 chunks	+54 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

John Gregg

9 years, 10 months ago (2011-02-18 23:11:48 UTC) #2

On 2011/02/18 04:32:31, akalin wrote:
> +johnnyg for review

LGTM

Expand Messages | Collapse Messages