Issue 6538034: Fix issue where params which are sub-strings of other params caused problems e.g. ro and cros_secure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6538034: Fix issue where params which are sub-strings of other params caused problems e.g. ro and cros_secure (Closed)

Created:
9 years, 10 months ago by jimhebert

Modified:
9 years, 7 months ago

Reviewers:
gauravsh

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master

Visibility:
Public.

Description

Fix issue where params which are sub-strings of other params caused problems e.g. ro and cros_secure Change-Id: Ic6dd5a883646103b32cfb58712df7d34725c5f62 BUG=chromium-os:12285 TEST=Ran ./ensure_secure_kernelparams.sh chromiumos_base_image.bin on today's mario build which had repro'd the bug Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=00b7d48

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixes for nits #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	scripts/image_signing/ensure_secure_kernelparams.sh	View	1	2 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

gauravsh

9 years, 10 months ago (2011-02-18 00:11:56 UTC) #2

lgtm

http://codereview.chromium.org/6538034/diff/1/scripts/image_signing/ensure_se...
File scripts/image_signing/ensure_secure_kernelparams.sh (right):

http://codereview.chromium.org/6538034/diff/1/scripts/image_signing/ensure_se...
scripts/image_signing/ensure_secure_kernelparams.sh:35: escape_regexmetas() {
add comment saying this escapes non-alphanumeric characters.

http://codereview.chromium.org/6538034/diff/1/scripts/image_signing/ensure_se...
scripts/image_signing/ensure_secure_kernelparams.sh:93: for param in
${required_kparams[@]}; do :
remove unnecessary colon at the end

http://codereview.chromium.org/6538034/diff/1/scripts/image_signing/ensure_se...
scripts/image_signing/ensure_secure_kernelparams.sh:106: for param in
${optional_kparams[@]}; do :
remove unnecessary colon at the end

Expand Messages | Collapse Messages