Issue 6538031: Move check for image until we actually need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6538031: Move check for image until we actually need it. (Closed)

Created:
9 years, 10 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

Move check for image until we actually need it. This addresses the case where we don't have chromiumos_image.bin but don't actually need it since we've previously generated a test image. Change-Id: Ie7be0165e0f68bbd9d34156b55e17d971cb86fa9 BUG=chromium-os:12268 TEST=Ran it with --noinplace and missing dev image. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9769c6b

Patch Set 1 #

Total comments: 1

Patch Set 2 : Die #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	mod_image_for_test.sh	View	1	2 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

9 years, 10 months ago (2011-02-17 20:00:41 UTC) #2

LGTM

http://codereview.chromium.org/6538031/diff/1/mod_image_for_test.sh
File mod_image_for_test.sh (right):

http://codereview.chromium.org/6538031/diff/1/mod_image_for_test.sh#newcode213
mod_image_for_test.sh:213: echo "No image found at $FLAGS_image to modify"
die

Expand Messages | Collapse Messages