A proposal for an initial postMessage interface. This will allow JavaScript ...

webkit/plugins/ppapi/ppapi_webplugin_impl.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/ppapi_webplugin_impl.h"
 
 #include <cmath>
 
 #include "base/message_loop.h"
 #include "ppapi/c/pp_var.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebPluginParams.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebPoint.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebRect.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
+#include "webkit/plugins/ppapi/message_channel.h"
 #include "webkit/plugins/ppapi/plugin_module.h"
 #include "webkit/plugins/ppapi/ppapi_plugin_instance.h"
 #include "webkit/plugins/ppapi/ppb_url_loader_impl.h"
 #include "webkit/plugins/ppapi/var.h"
 
 using WebKit::WebCanvas;
 using WebKit::WebPluginContainer;
 using WebKit::WebPluginParams;
 using WebKit::WebPoint;
 using WebKit::WebRect;
@@ skipping 58 matching lines @@
     instance_->Delete();
     instance_ = NULL;
   }
 
   MessageLoop::current()->DeleteSoon(FROM_HERE, this);
 }
 
 NPObject* WebPluginImpl::scriptableObject() {
   scoped_refptr<ObjectVar> object(
       ObjectVar::FromPPVar(instance_->GetInstanceObject()));
-  if (object)
-    return object->np_object();
+  if (object) {
+    instance_->

[brettw, 2011/03/16 21:34:11]

I'd probably have wrapped this like:
instance_->message_channel().set_passthrough_object(
    object->np_object());
to avoid breaking after the ->

+        message_channel().set_passthrough_object(object->np_object());
+  }
+  return instance_->message_channel().np_object();
   return NULL;
 }
 
 void WebPluginImpl::paint(WebCanvas* canvas, const WebRect& rect) {
   if (!instance_->IsFullscreenOrPending())
     instance_->Paint(canvas, plugin_rect_, rect);
 }
 
 void WebPluginImpl::updateGeometry(
     const WebRect& window_rect,
@@ skipping 115 matching lines @@
   return instance_->PrintPage(page_number, canvas);
 }
 
 void WebPluginImpl::printEnd() {
   return instance_->PrintEnd();
 }
 
 }  // namespace ppapi
 }  // namespace webkit