A proposal for an initial postMessage interface. This will allow JavaScript ...

ppapi/tests/testing_instance.h

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef PPAPI_TEST_TESTING_INSTANCE_H_
-#define PPAPI_TEST_TESTING_INSTANCE_H_
+#ifndef PPAPI_TESTS_TESTING_INSTANCE_H_
+#define PPAPI_TESTS_TESTING_INSTANCE_H_
 
 #include <string>
 
 #include "ppapi/cpp/completion_callback.h"
 #include "ppapi/cpp/instance.h"
 
 class TestCase;
 
 class TestingInstance : public pp::Instance {
  public:
-  TestingInstance(PP_Instance instance);
+  explicit TestingInstance(PP_Instance instance);
 
   // pp::Instance override.
   virtual bool Init(uint32_t argc, const char* argn[], const char* argv[]);
   virtual void DidChangeView(const pp::Rect& position, const pp::Rect& clip);
   virtual pp::Var GetInstanceObject();
 
   // Outputs the information from one test run, using the format
   //   <test_name> [PASS|FAIL <error_message>]
   // If error_message is empty, we say the test passed and emit PASS. If
   // error_message is nonempty, the test failed with that message as the error
   // string.
   //
   // Intended usage:
   //   LogTest("Foo", FooTest());
   //
   // Where FooTest is defined as:
   //   std::string FooTest() {
   //     if (something_horrible_happened)
   //       return "Something horrible happened";
   //     return "";
   //   }
   void LogTest(const std::string& test_name, const std::string& error_message);
 
   // Appends an error message to the log.
   void AppendError(const std::string& message);
 
+  // Passes the message_data through to the HandleMessage method on the
+  // TestClass object that's associated with this instance.
+  virtual void HandleMessage(const pp::Var& message_data);
+
+  bool nacl_mode() { return nacl_mode_; }

[brettw, 2011/03/16 21:34:11]

This should be const.

[dmichael(do not use this one), 2011/03/21 21:43:35]

Nice catch.  Turns out I didn't end up using it, so I just cut it.

+
  private:
   void ExecuteTests(int32_t unused);
 
   // Creates a new TestCase for the give test name, or NULL if there is no such
   // test. Ownership is passed to the caller.
   TestCase* CaseForTestName(const char* name);
 
   // Appends a list of available tests to the console in the document.
   void LogAvailableTests();
 
@@ skipping 14 matching lines @@
   // Set once the tests are run so we know not to re-run when the view is sized.
   bool executed_tests_;
 
   // Collects all errors to send the the browser. Empty indicates no error yet.
   std::string errors_;
 
   // True if running in Native Client.
   bool nacl_mode_;
 };
 
-#endif  // PPAPI_TEST_TESTING_INSTANCE_H_
+#endif  // PPAPI_TESTS_TESTING_INSTANCE_H_
+