Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4832)

Unified Diff: chrome/installer/util/installer_state_unittest.cc

Issue 6538025: Temp dir cleanup:... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/installer_state_unittest.cc
===================================================================
--- chrome/installer/util/installer_state_unittest.cc (revision 75264)
+++ chrome/installer/util/installer_state_unittest.cc (working copy)
@@ -11,6 +11,7 @@
#include "base/file_util.h"
#include "base/path_service.h"
#include "base/process_util.h"
+#include "base/scoped_temp_dir.h"
#include "base/string_util.h"
#include "base/utf_string_conversions.h"
#include "base/version.h"
@@ -118,7 +119,12 @@
MockInstallerState installer_state;
BuildSingleChromeState(chrome_dir, &installer_state);
scoped_ptr<Version> latest_version(Version::GetVersionFromString("1.0.4.0"));
- installer_state.RemoveOldVersionDirectories(*latest_version.get());
+ {
+ ScopedTempDir temp_dir;
+ ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
+ installer_state.RemoveOldVersionDirectories(*latest_version.get(),
+ temp_dir.path());
+ }
// old versions should be gone
EXPECT_FALSE(file_util::PathExists(chrome_dir_1));
@@ -193,7 +199,12 @@
MockInstallerState installer_state;
BuildSingleChromeState(chrome_dir, &installer_state);
scoped_ptr<Version> latest_version(Version::GetVersionFromString("1.0.4.0"));
- installer_state.RemoveOldVersionDirectories(*latest_version.get());
+ {
+ ScopedTempDir temp_dir;
+ ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
+ installer_state.RemoveOldVersionDirectories(*latest_version.get(),
+ temp_dir.path());
+ }
// old versions not in used should be gone
EXPECT_FALSE(file_util::PathExists(chrome_dir_1));
@@ -265,7 +276,12 @@
EXPECT_TRUE(file.IsValid());
EXPECT_TRUE(file_util::PathExists(old_chrome_dll));
- installer_state.RemoveOldVersionDirectories(*new_version.get());
+ ScopedTempDir temp_dir;
+ ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
+
+ installer_state.RemoveOldVersionDirectories(*new_version.get(),
+ temp_dir.path());
+
// The old directory should still exist.
EXPECT_TRUE(file_util::PathExists(old_version_dir));
EXPECT_TRUE(file_util::PathExists(new_version_dir));
@@ -273,7 +289,8 @@
// Now close the file handle to make it possible to delete our key file.
file.Close();
- installer_state.RemoveOldVersionDirectories(*new_version.get());
+ installer_state.RemoveOldVersionDirectories(*new_version.get(),
+ temp_dir.path());
// The new directory should still exist.
EXPECT_TRUE(file_util::PathExists(new_version_dir));

Powered by Google App Engine
This is Rietveld 408576698