Temp dir cleanup:...

chrome/installer/setup/chrome_frame_quick_enable.cc

Index: chrome/installer/setup/chrome_frame_quick_enable.cc
===================================================================
--- chrome/installer/setup/chrome_frame_quick_enable.cc	(revision 75264)
+++ chrome/installer/setup/chrome_frame_quick_enable.cc	(working copy)
@@ -7,6 +7,7 @@
 #include <windows.h>
 
 #include "base/logging.h"
+#include "base/scoped_temp_dir.h"
 #include "base/string_util.h"
 #include "base/win/registry.h"
 #include "chrome/installer/setup/install_worker.h"
@@ -79,6 +80,11 @@
       LOG(ERROR) << "AddProduct failed";
       status = INSTALL_FAILED;
     } else {
+      ScopedTempDir temp_path;
+      if (!temp_path.CreateUniqueTempDir()) {
+        LOG(ERROR) << "Failed to create Temp directory";

[tommi (sloooow) - chröme, 2011/02/17 20:00:49]

I think PLOG would be useful here.  Things that can fail are GetTempPath and
CreateDirectory.

[grt (UTC plus 2), 2011/02/17 20:26:41]

Great suggestion.  Done here and for all other CreateUnique* calls.

+        return INSTALL_FAILED;
+      }
       scoped_ptr<WorkItemList> item_list(WorkItem::CreateWorkItemList());
       const ProductState* chrome_state =
           machine_state.GetProductState(installer_state->system_install(),
@@ -106,7 +112,7 @@
 
       const Version* opv = chrome_state->old_version();
       AppendPostInstallTasks(*installer_state, setup_path, new_chrome_exe, opv,
-                             new_version, item_list.get());
+                             new_version, temp_path.path(), item_list.get());
 
       // Before updating the channel values, add Chrome back to the mix so that
       // all multi-installed products' channel values get updated.