Switch DOMAutomationTest.FindByXPath from FLAKY to DISABLED.

Switch DOMAutomationTest.FindByXPath from FLAKY to DISABLED.
It's timing out and still causing the test suite to go red.

BUG=61636
TEST=none
TBR=nsylvain

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75276

[Robert Sesek, 2011-02-17 16:17:14]

You were right about this test yesterday.

[Nicolas Sylvain, 2011-02-17 16:45:33]

Doing this will make the next test timeout.

There are 2 ways of fixing this

1. revert pawel's patch (his revert of my patch to increase the timeout for
those tests)
2. fix pawel's patch (to make sure his EmptyTest is correctly run on the
buildbots.

Nicolas


On Thu, Feb 17, 2011 at 8:17 AM, <rsesek@chromium.org> wrote:

> Reviewers: Nicolas Sylvain,
>
> Message:
> You were right about this test yesterday.
>
> Description:
> Switch DOMAutomationTest.FindByXPath from FLAKY to DISABLED.
> It's timing out and still causing the test suite to go red.
>
> BUG=61636
> TEST=none
> TBR=nsylvain
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75276
>
> Please review this at http://codereview.chromium.org/6538023/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/test/automation/dom_automation_browsertest.cc
>
>
> Index: chrome/test/automation/dom_automation_browsertest.cc
> diff --git a/chrome/test/automation/dom_automation_browsertest.cc
> b/chrome/test/automation/dom_automation_browsertest.cc
> index
>
85f287473c257d5a6eb7e014b89ed5ca45b0aec9..e76c514a37262ee79b54503c59a9debe71188ec4
> 100644
> --- a/chrome/test/automation/dom_automation_browsertest.cc
> +++ b/chrome/test/automation/dom_automation_browsertest.cc
> @@ -33,7 +33,7 @@ typedef DOMElementProxy::By By;
>
>  #if defined(OS_WIN)
>  // See http://crbug.com/61636
> -#define MAYBE_FindByXPath FLAKY_FindByXPath
> +#define MAYBE_FindByXPath DISABLED_FindByXPath
>  #else
>  #define MAYBE_FindByXPath FindByXPath
>  #endif
>
>
>

[Paweł Hajdan Jr., 2011-02-17 20:50:03]

On 2011/02/17 16:45:33, Nicolas Sylvain wrote:
> 1. revert pawel's patch (his revert of my patch to increase the timeout for
> those tests)

Please don't do that if possible.

> 2. fix pawel's patch (to make sure his EmptyTest is correctly run on the
> buildbots.

I'd like to do that, but I'm not sure what's going on on the bots. When run on
the tryserver the empty test got executed. I really don't know why the bot
doesn't run it. Does it happen on every Windows bot?

[Robert Sesek, 2011-02-17 20:56:49]

On Thu, Feb 17, 2011 at 3:50 PM, <phajdan.jr@chromium.org> wrote:

> On 2011/02/17 16:45:33, Nicolas Sylvain wrote:
>
>> 1. revert pawel's patch (his revert of my patch to increase the timeout
>> for
>> those tests)
>>
>
> Please don't do that if possible.


I haven't yet because this change seems to hold OK.


>  2. fix pawel's patch (to make sure his EmptyTest is correctly run on the
>> buildbots.
>>
>
> I'd like to do that, but I'm not sure what's going on on the bots. When run
> on
> the tryserver the empty test got executed. I really don't know why the bot
> doesn't run it. Does it happen on every Windows bot?
>
>
No, only on Win-dbg-3, as far as I can tell.

http://codereview.chromium.org/6538023/