Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 6538015: Add --arch flag to pack mode of vbutil_kernel (Closed)

Created:
9 years, 10 months ago by Che-Liang Chiou
Modified:
9 years ago
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Add --arch flag to pack mode of vbutil_kernel When --arch flag is not x86, x86-only operations in pack mode are turned off so that we can reuse vbutil_kernel to generate kernel partition images for other targets, such as arm. See CL:6538014 for its application. BUG=chromium-os:3790 TEST=Run "emerge vboot_reference" successfully Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=0376203

Patch Set 1 #

Patch Set 2 : Change --notx86 to --arch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -16 lines) Patch
M utility/vbutil_kernel.c View 1 10 chunks +49 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Che-Liang Chiou
9 years, 10 months ago (2011-02-17 09:23:16 UTC) #1
Bill Richardson
LGTM
9 years, 10 months ago (2011-02-17 17:36:28 UTC) #2
Randall Spangler
LGTM Though I'd tend to call the param --no-x86 so it looks like a boolean ...
9 years, 10 months ago (2011-02-17 20:25:36 UTC) #3
Che-Liang Chiou
Hi, Reviewer of another CL (6538014) suggests changing --notx86 to --arch. PTAL. Thanks. On 2011/02/17 ...
9 years, 10 months ago (2011-02-21 11:12:30 UTC) #4
Randall Spangler
On Mon, Feb 21, 2011 at 3:12 AM, <clchiou@chromium.org> wrote: > Hi, > > Reviewer ...
9 years, 10 months ago (2011-02-21 17:17:41 UTC) #5
Che-Liang Chiou
9 years, 10 months ago (2011-02-22 02:20:40 UTC) #6
Thanks. I will make x86 default.

On 2011/02/21 17:17:41, Randall Spangler wrote:
> On Mon, Feb 21, 2011 at 3:12 AM, <mailto:clchiou@chromium.org> wrote:
> 
> > Hi,
> >
> > Reviewer of another CL (6538014) suggests changing --notx86 to --arch.
> > PTAL.
> >
> 
> That's an even better idea.  Then --arch=x86 is the default and includes
> those sections, and --arch=arm doesn't.
> 
> - Randall
> 
> 
> > Thanks.
> >
> > On 2011/02/17 20:25:36, Randall Spangler wrote:
> >
> >> LGTM
> >>
> >
> >  Though I'd tend to call the param --no-x86 so it looks like a boolean
> >> --x86
> >>
> > flag
> >
> >> (like shutils).  That'll be nicer if later we decide to make the x86 stuff
> >> default to off (and --x86 turns it on).
> >>
> >
> >
> >
> > http://codereview.chromium.org/6538015/
> >

Powered by Google App Engine
This is Rietveld 408576698