Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3128)

Unified Diff: bin/cros_make_image_bootable

Issue 6538014: Add transitional flag for enabling arm kernel signing (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crosutils.git@master
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build_image » ('j') | build_image » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bin/cros_make_image_bootable
diff --git a/bin/cros_make_image_bootable b/bin/cros_make_image_bootable
index c1a2d0e2b56926bae6a374b036f2d8dcfef8f77f..ce7b53458bfae925e144cef6085d95e35c063c4f 100755
--- a/bin/cros_make_image_bootable
+++ b/bin/cros_make_image_bootable
@@ -117,6 +117,10 @@ DEFINE_string espfs_mountpoint "/tmp/espfs" \
DEFINE_boolean use_dev_keys ${FLAGS_FALSE} \
"Use developer keys for signing. (Default: false)"
+# TODO(clchiou): Change default to FLAGS_TRUE once ARM verify boot is stable?
+DEFINE_boolean enable_kernel_signing ${FLAGS_FALSE} \
Will Drewry 2011/02/17 16:54:09 same comment from other files :)
Che-Liang Chiou 2011/02/21 11:08:39 Done.
+ "Sign kernel partition for ARM images."
+
# TODO(sosa): Remove once known images no longer use this in their config.
DEFINE_string arm_extra_bootargs "" "DEPRECATED FLAG. Do not use."
@@ -128,6 +132,12 @@ FLAGS "${@}" || exit 1
# so will die prematurely if 'set -e' is specified before now.
set -e -u
+if [[ ${FLAGS_enable_kernel_signing} -eq ${FLAGS_TRUE} ]]; then
+ enable_kernel_signing_flag="--enable_kernel_signing"
+else
+ enable_kernel_signing_flag="--noenable_kernel_signing"
+fi
+
# $1 - Directory where developer rootfs is mounted.
# $2 - Directory where developer stateful_partition is mounted.
# $3 - Directory where the ESP partition is mounted.
@@ -193,6 +203,7 @@ make_image_bootable() {
--verity_error_behavior=${FLAGS_verity_error_behavior} \
--root=${cros_root} \
--keys_dir="${FLAGS_keys_dir}" \
+ ${enable_kernel_signing_flag} \
${use_dev_keys}
local rootfs_hash_size=$(stat -c '%s' ${FLAGS_rootfs_hash})
« no previous file with comments | « no previous file | build_image » ('j') | build_image » ('J')

Powered by Google App Engine
This is Rietveld 408576698