Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 6538005: Update the NSS patches. Add snapstart2.patch and peercertchain.patch.... (Closed)

Created:
9 years, 10 months ago by wtc
Modified:
9 years, 7 months ago
Reviewers:
agl, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Update the NSS patches. Add snapstart2.patch and peercertchain.patch. Tweak sslimpl.h to eliminate one conflict when applying clientauth.patch. Unfortunately one conflict in sslimpl.h and one conflict in ssl3con.c still remain in clientauth.patch. Add the applypatches.sh script to make it easier to apply the patches. R=agl BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75311

Patch Set 1 #

Patch Set 2 : Describe patches/applypatches.sh in README.chromium #

Total comments: 1

Patch Set 3 : Upload before checkin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -32 lines) Patch
M net/third_party/nss/README.chromium View 1 2 chunks +7 lines, -0 lines 0 comments Download
A net/third_party/nss/patches/applypatches.sh View 1 chunk +28 lines, -0 lines 0 comments Download
M net/third_party/nss/patches/clientauth.patch View 11 chunks +24 lines, -23 lines 0 comments Download
A net/third_party/nss/patches/peercertchain.patch View 1 chunk +81 lines, -0 lines 0 comments Download
A net/third_party/nss/patches/snapstart2.patch View 1 chunk +93 lines, -0 lines 0 comments Download
M net/third_party/nss/ssl/sslimpl.h View 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wtc
agl: please review this patch. I'm getting ready to merge with NSS 3.12.9. I will ...
9 years, 10 months ago (2011-02-17 00:04:29 UTC) #1
Ryan Sleevi
wtc: Am I correct in assuming by "as many as possible" you mean excluding the ...
9 years, 10 months ago (2011-02-17 00:39:31 UTC) #2
wtc
rsleevi: clientauth.patch cannot be upstreamed in the current form. Don't worry.
9 years, 10 months ago (2011-02-17 00:43:06 UTC) #3
agl
9 years, 10 months ago (2011-02-17 16:24:27 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698