Issue 6538: Moved the function GetValue from the code generator to the Reference...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6538: Moved the function GetValue from the code generator to the Reference... (Closed)

Created:
12 years, 2 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
iposva, Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Moved the function GetValue from the code generator to the Reference helper class. As a consequence, also removed the optional Reference from the code generator state and got rid of some state-dependent behavior in the code generator. Committed: http://code.google.com/p/v8/source/detail?r=466

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+328 lines, -363 lines)			Patch
	M	src/codegen-arm.cc	View		35 chunks	+162 lines, -177 lines	2 comments	Download
	M	src/codegen-ia32.cc	View	1	32 chunks	+166 lines, -186 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

iposva

12 years, 2 months ago (2008-10-07 19:43:31 UTC) #2

LGTM

-Ivan

http://codereview.chromium.org/6538/diff/202/203
File src/codegen-arm.cc (right):

http://codereview.chromium.org/6538/diff/202/203#newcode3475
Line 3475: // distinction between expressions ina typeof and not in a typeof. If
ina -> in a

http://codereview.chromium.org/6538/diff/202/203#newcode3498
Line 3498: // distinction between expressions ina typeof and not in a typeof.
ina -> in a

http://codereview.chromium.org/6538/diff/202/204
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/6538/diff/202/204#newcode1606
Line 1606: }
Thanks!

Expand Messages | Collapse Messages