Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 6537018: Fix incorrect deoptimization for logical not in an effect context. (Closed)

Created:
9 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix incorrect deoptimization for logical not in an effect context. The baseline compiler does not materialize a value for expressions of the form !expr in an effect context so the graph translation should not produce such an environment, otherwise we risk targeting it by deoptimization. BUG=v8:1167 Committed: http://code.google.com/p/v8/source/detail?r=6833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
M src/hydrogen.cc View 2 chunks +5 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-1167.js View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 10 months ago (2011-02-17 12:46:27 UTC) #1
Mads Ager (chromium)
9 years, 10 months ago (2011-02-17 12:50:05 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698