Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 6537003: Merge 78648 - 2011-02-15 James Robinson <jamesr@chromium.org>... (Closed)

Created:
9 years, 10 months ago by jamesr
Modified:
9 years, 6 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/648/
Visibility:
Public.

Description

Merge 78648 - 2011-02-15 James Robinson <jamesr@chromium.org>; Reviewed by Alexey Proskuryakov. requestAnimationFrame callbacks should not fire within a modal dialog https://bugs.webkit.org/show_bug.cgi?id=53188 Tests that requestAnimationFrame callbacks are suspended while a modal dialog is showing. * fast/animation/request-animation-frame-during-modal-expected.txt: Added. * fast/animation/request-animation-frame-during-modal.html: Added. 2011-02-15 James Robinson <jamesr@chromium.org>; Reviewed by Alexey Proskuryakov. requestAnimationFrame callbacks should not fire within a modal dialog https://bugs.webkit.org/show_bug.cgi?id=53188 requestAnimationFrame callbacks shouldn't fire while a modal dialog is up (like a window.alert()). This matches Firefox and other async APIs. This patch moves the callback servicing into its own controller class which receives notifications on suspend/resume. Test: fast/animation/request-animation-frame-during-modal.html * WebCore.gypi: * bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setJavaScriptPaused): * dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::suspendScriptedAnimationControllerCallbacks): (WebCore::Document::resumeScriptedAnimationControllerCallbacks): (WebCore::Document::webkitRequestAnimationFrame): (WebCore::Document::webkitCancelRequestAnimationFrame): (WebCore::Document::serviceScriptedAnimations): * dom/Document.h: * dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::suspendScriptedAnimationControllerCallbacks): (WebCore::ScriptExecutionContext::resumeScriptedAnimationControllerCallbacks): * dom/ScriptedAnimationController.cpp: Added. (WebCore::ScriptedAnimationController::ScriptedAnimationController): (WebCore::ScriptedAnimationController::suspend): (WebCore::ScriptedAnimationController::resume): (WebCore::ScriptedAnimationController::registerCallback): (WebCore::ScriptedAnimationController::cancelCallback): (WebCore::ScriptedAnimationController::serviceScriptedAnimations): * dom/ScriptedAnimationController.h: Added. (WebCore::ScriptedAnimationController::create): * history/CachedFrame.cpp: (WebCore::CachedFrameBase::restore): (WebCore::CachedFrame::CachedFrame): * page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer): TBR=jamesr@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7610 lines, -110 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +3081 lines, -0 lines 0 comments Download
A + LayoutTests/fast/animation/request-animation-frame-during-modal.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/ChangeLog View 3 chunks +4488 lines, -41 lines 0 comments Download
M Source/WebCore/WebCore.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/bindings/js/ScriptDebugServer.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/WebCore/dom/Document.h View 3 chunks +5 lines, -3 lines 0 comments Download
M Source/WebCore/dom/Document.cpp View 4 chunks +26 lines, -68 lines 0 comments Download
M Source/WebCore/dom/ScriptExecutionContext.h View 1 chunk +3 lines, -0 lines 0 comments Download
A + Source/WebCore/dom/ScriptedAnimationController.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/WebCore/dom/ScriptedAnimationController.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/history/CachedFrame.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/WebCore/page/PageGroupLoadDeferrer.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
9 years, 10 months ago (2011-02-16 21:47:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698