Issue 6537001: Fix is_convertible for windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6537001: Fix is_convertible for windows. (Closed)

Created:
9 years, 10 months ago by awong

Modified:
9 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix is_convertible for windows. It turns out that if you nest a template inside the initializer list of another template, the namelookup in windows gets all funky. In this case, it couldn't tell that the found name was a function. Luckily, we could just move the template parameters one level deeper. BUG=none TEST=unittests & trybots. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75194

Patch Set 1 #

Patch Set 2 : Silly Type conversion warning. #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -16 lines)			Patch
	M	base/template_util.h	View		3 chunks	+11 lines, -12 lines	0 comments	Download
	M	base/template_util_unittest.cc	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages