Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 6534029: Change behavior of global declarations in the presence of setters. (Closed)

Created:
9 years, 10 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Change behavior of global declarations in the presence of setters. Call accessors in the global object prototype when initializing global variables. Function declarations are special cased for compatibility with Safari and setters are not called for them. If this special casing was not done webkit layout tests would fail. Make the declaration of global const variables in the presence of callbacks a redeclaration error. Handle const context slot declarations conflicting with a CALLBACK as a redeclaration error. That is, unless it is on a context extension object which is not a real object and therefore conceptually have no accessors in prototype chains. Accessors in prototype chains of context extension objects are explicitly ignored in SetProperty. Committed: http://code.google.com/p/v8/source/detail?r=6846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -43 lines) Patch
M src/runtime.cc View 5 chunks +49 lines, -32 lines 0 comments Download
M test/cctest/test-decls.cc View 4 chunks +4 lines, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-1170.js View 1 chunk +35 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
9 years, 10 months ago (2011-02-17 20:52:21 UTC) #1
Kevin Millikin (Chromium)
9 years, 10 months ago (2011-02-17 21:00:59 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698