Issue 6534021: Implemented a policy to match the ClearSiteDataOnExit pref.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6534021: Implemented a policy to match the ClearSiteDataOnExit pref. (Closed)

Created:
9 years, 10 months ago by pastarmovj

Modified:
9 years, 7 months ago

Reviewers:
Mattias Nissler (ping if slow)

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Implemented a policy to match the ClearSiteDataOnExit pref. When set this policy overrides the user settings for that pref. No UI changes have been made to ContentSettings.xib only wired the enabled flag to the managed property of the underlaying pref. BUG=59775 TEST=Manually set the policy and check if the corresponding UI element is disabled and correspond to the policy state. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75383

Patch Set 1 #

Patch Set 2 : Added the mac implementation and rebased to ToT. #

Total comments: 1

Patch Set 3 : Improved policy description. #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -4 lines)			Patch
M	chrome/app/nibs/ContentSettings.xib	View	1	3 chunks	+22 lines, -2 lines	0 comments	Download
M	chrome/app/policy/policy_templates.json	View	1 2	2 chunks	+14 lines, -1 line	0 comments	Download
M	chrome/browser/policy/configuration_policy_pref_store.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/options/content_settings_dialog_controller.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/options/content_settings_dialog_controller.mm	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/options/cookie_filter_page_gtk.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/options/cookie_filter_page_view.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pastarmovj

Please take a look at this small CL. It defines and wires the ClearSiteDataOnExit policy ...

9 years, 10 months ago (2011-02-17 16:34:32 UTC) #1

Mattias Nissler (ping if slow)

9 years, 10 months ago (2011-02-17 16:41:47 UTC) #2

LGTM pending a better description text and trybot happiness.

http://codereview.chromium.org/6534021/diff/6/chrome/app/policy/policy_templa...
File chrome/app/policy/policy_templates.json (right):

http://codereview.chromium.org/6534021/diff/6/chrome/app/policy/policy_templa...
chrome/app/policy/policy_templates.json:442: 'desc': '''When set <ph
name="PRODUCT_NAME">$1<ex>Google Chrome</ex></ph> will delete all locally stored
data from the browser.''',
maybe add "upon shutdown". Maybe be more specific of what data exactly gets
deleted.

Expand Messages | Collapse Messages